Support redis max_receives config option
#100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jaymell
force-pushed
the
james/redis-max-attempts-functions
branch
2 times, most recently
from
5d6fcc6
to
4c01ad0
Compare
jaymell
force-pushed
the
james/redis-max-attempts-functions
branch
3 times, most recently
from
ba3f9e2
to
d833b06
Compare
This adds a `max_receives` option to both Redis queue implementations. This is the first step in supporting deadletter queuing. `InternalPayload` type aliases have been added to represent Omniqueue items that track the current number of times a message has been received (`num_receives`). `num_receives` is incremented whenever an item is re-queued from the pending/processing queues until it hits `max_receives`, at which point the message is abandoned. Later we will support putting this in an optional deadletter queue. I originally tried adding a proper struct for `InternalPayload`, but I don't think that clarified anything and was less memory optimal, so the relevant logic has been captured in simple functions/ a macro instead.
jaymell
force-pushed
the
james/redis-max-attempts-functions
branch
from
d833b06
to
a49ab47
Compare
svix-jplatte
reviewed
Sep 2, 2024
jaymell
force-pushed
the
james/redis-max-attempts-functions
branch
from
90b5b12
to
0345177
Compare
Also address other review comments
jaymell
force-pushed
the
james/redis-max-attempts-functions
branch
from
0345177
to
d6f3741
Compare
svix-jplatte
approved these changes
Sep 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a
max_receivesoption to both Redis queue implementations.This is the first step in supporting deadletter queuing.
InternalPayloadtype aliases have been added to represent Omniqueueitems that track the current number of times a message has been
received (
num_receives).num_receivesis incremented wheneveran item is re-queued from the pending/processing queues until it
hits
max_receives, at which point the message is abandoned. Laterwe will support putting this in an optional deadletter queue.
I originally tried adding a proper struct for
InternalPayload, butI don't think that clarified anything and was less memory optimal,
so the relevant logic has been captured in simple functions/macro
instead.