Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Custom preview url #169

Open
mattickx opened this issue Jun 20, 2024 · 7 comments
Open

Custom preview url #169

mattickx opened this issue Jun 20, 2024 · 7 comments
Labels
enhancement New feature or request

Comments

@mattickx
Copy link

A couple of years ago I've managed to run Decap CMS with custom preview links (iframe + passing data to it):
decaporg/decap-cms#2183 (comment)

Would something similar be possible today with sceltia-cms ?

@kyoshino
Copy link
Member

Hi there 👋🏻 I was actually trying to implement an ifame preview a few months ago. There were some issues, but will take a look again.

@kyoshino kyoshino self-assigned this Jun 20, 2024
@kyoshino kyoshino added the enhancement New feature or request label Jun 20, 2024
@mattickx
Copy link
Author

Hi there 👋🏻 I was actually trying to implement an ifame preview a few months ago. There were some issues, but will take a look again.

Great! Thank you very much.

I'm not too familiar with the underlying structure, but I noticed that CMS.registerPreviewTemplate is not compatible.

Here's what I basically achieved and want to reproduce with Sveltia CMS:

  • Make it possible to customize the preview URL per collection.
  • Render the preview with an iframe, passing data of the current open file and updating it when editing.

If this becomes part of the project for official support, that would be even better!

@kyoshino
Copy link
Member

kyoshino commented Jun 20, 2024

Yeah, CMS.registerPreviewTemplate is not yet supported in Sveltia. I was thinking about enabling an iframe preview by simply configuring a preview URL, without using the method. IIRC, I encountered at least 2 issues:

  • It may be difficult or impossible to preview a new entry draft (an existing entry is fine) because the data is not saved and the entry URL/slug is not determined yet
  • The previewed page may be reloaded for every single change/keystroke unless the framework’s hot reload works well

Will dive into it further.

@mattickx
Copy link
Author

I encountered at least 2 issues:

  • It may be difficult or impossible to preview a new entry draft (an existing entry is fine) because the data is not saved and the entry URL/slug is not determined yet

As you can see in my old example, with NetlifyCMS you had access to the current editing data. Not sure if this is available in Sveltia.
I used that data and put it in a variable on the window object.

  • The previewed page may be reloaded for every single change/keystroke unless the framework’s hot reload works well

Will dive into it further.

Since the preview is rendered with an iframe, you can access a variable in the parent's iframe DOM's window.
Inside my own project (using the CMS) I've set an interval on my preview page that retrieves the parent's iframe data and updates the view.


This way, there's no need for the CMS to refresh or rerender anything, especially not on each keystroke.
Instead, you could update the variable in the CMS DOM's window only when necessary (on blur or some other event).

On the user project side, for standardization and ease of use, the polling of the content on the preview page could be hidden behind a utility function in a module or SDK.

@bummzack
Copy link

bummzack commented Oct 9, 2024

I've just discovered this project and I'm delighted about it. We are big fans of Svelte and we also used Netlify/Decap CMS in some of our projects. Having a preview was always one of the features we missed the most…

I think an iframe should work, but I would suggest to use the postMessage API for communication.

I imagine something like this:

  • each collection can have a preview URL, ideally with dynamic parts, such as https://example.com/page/{{slug}}?preview=true, where {{slug}} would be replaced with the slug property from the current collection entry.
  • if specified, the preview URL is loaded in an iframe (instead of the default preview)
  • Whenever content is changed in the CMS, the updated content is sent to the iframe window via postMessage.
  • The frontend running in the preview iframe could then listen to message event and update data dynamically.

I think this would be an approach that should work with quite a lot of stacks/frameworks/etc.

@kyoshino kyoshino removed their assignment Nov 13, 2024
@martendegroot
Copy link

@kyoshino , I landed here straight from google looking for the same thing. Has something like this already been added? It would be great to render some style on top of the bare preview pane. If there's a registered open issue assigned to this feature request, I'd love to follow it.

@kyoshino
Copy link
Member

kyoshino commented Nov 23, 2024

Not yet implemented. I’ll work on it in a few months and close this ticket once done 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

4 participants