Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace sorcery #637

Closed
benmccann opened this issue Jun 11, 2024 · 4 comments
Closed

Replace sorcery #637

benmccann opened this issue Jun 11, 2024 · 4 comments

Comments

@benmccann
Copy link
Member

benmccann commented Jun 11, 2024

Is your feature request related to a problem? Please describe.

sorcery is outdated and unmaintained. It prints deprecation warnings for users. It also adds a dependency that isn't used elsewhere in the Svelte ecosystem

Describe the solution you'd like

Replace sorcery with @ampproject/remapping like we do in Svelte

const chain = await load(`${filename}.js`, sourceMapChain);

https://github.com/sveltejs/svelte/blob/84ad208f2e986fa549683a12e7f999c3d31b127f/packages/svelte/package.json#L132

I wonder if we even need to combine source maps though? What is injectVarsToCode doing?

Describe alternatives you've considered

Update sorcery. But even then it'd be nice to have fewer dependencies in a new SvelteKit app

How important is this feature to you?

Important at the moment because it's causing sveltejs/kit#12258

@benmccann
Copy link
Member Author

This would fix #636 as well

@benmccann
Copy link
Member Author

We're fixing up sander right now, which makes this less necessary, but it'd still be nice to do to reduce the dependency footprint of svelte-preprocess

@dummdidumm
Copy link
Member

This can be ripped out entirely as part of a major if we do one soon - this code is from a time when typescript didn't have good support for separating between value and type imports

@dummdidumm
Copy link
Member

Removed as part of #640

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants