Remove external
from adapter-vercel
?
#8756
Rich-Harris
announced in
Announcements
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
adapter-vercel
has anexternal
option that I'm pretty sure is useless. It's used when creating edge functions, which are bundled withesbuild
, but I'm 99% sure that edge functions won't work if you have external dependencies — everything needs to be bundled together.As far as I can tell, the option is vestigial — we needed it at one time because we were using
esbuild
for serverless functions, and sometimes you'd need to exclude certain dependencies likesharp
. But we no longer useesbuild
in that context, so I don't believe there's any reason to keep it.Am I missing anything?
Beta Was this translation helpful? Give feedback.
All reactions