Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

mcts is reset after every episode? #292

Open
tueboesen opened this issue Jan 10, 2023 · 2 comments
Open

mcts is reset after every episode? #292

tueboesen opened this issue Jan 10, 2023 · 2 comments

Comments

@tueboesen
Copy link

I am not an expert in mcts at all, but I have been playing around with your code and I noticed that in the learn method the mcts is reset after every single episode. Meaning the mcts is reset after every single game when it is generating data to train on. Hence the mcts never grows beyond the information of a single game, this seems weird to me since I would expect you to want to keep the mcts and continue to evolve it and only reset it once the neural network has been trained on the data generated?

Is this really intended?

@arnemileswinter
Copy link

If i understand your question correctly, it's what they do in AlphaGoZero too:

The search tree is reused at subsequent time-steps: the child node corresponding to the played action becomes the new root node; the subtree below this child is retained along with all its statistics, while the remainder of the tree is discarded.

so i think it is intended.
Have you tried reusing the tree? (I would guess that the memory footprint will be ginormous, though)

@cyshe
Copy link

cyshe commented Jul 9, 2024

args.numMCTSSims games are played when calling getActionProb for each MCTS.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants