Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed blurred ellipses under five main menu options #5222

Closed
wants to merge 1 commit into from
Closed

Removed blurred ellipses under five main menu options #5222

wants to merge 1 commit into from

Conversation

halynnj
Copy link

@halynnj halynnj commented Dec 10, 2024

Agreement

By creating a pull request in stk-code, you hereby agree to dual-license your contribution as
GNU General Public License version 3 or any later version and
Mozilla Public License version 2 or any later version.

This includes your previous contribution(s) under the same name of contributor.

Keep the above statement in the pull request comment for agreement.

Fixes #5109

I decided to remove the glow all together, I think it looks pretty clean that way.

@CodingJellyfish
Copy link
Member

Hi. I cannot pass this PR, because it literally hardcodes the cases of specific screens, instead of a generic solution.
My suggestion is, if an icon button have specified its focus image, it shouldn't have glow when focused. Maybe you can implement smth like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[GUI] Consider removing blurred elipse from 5 main menu entries
2 participants
@halynnj @CodingJellyfish