Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

normalizeSuperJsonDocument function and hidden env variables resolution #288

Open
freaz opened this issue Aug 31, 2022 · 0 comments
Open
Labels
enhancement New feature or request

Comments

@freaz
Copy link
Member

freaz commented Aug 31, 2022

It is easy to miss, that without passing environment to the function env variables won't be resolved.

Main issue I see, is not expected behaviour inside SuperJson normalization.

Expected Behaviour

Not sure what would be the best, but can imagine one of the following solutions:

  1. environment will be mandatory parameter
  2. environment variables resolution will happen in separate function

Current Behavior

Silently skips resolution.

Possible Solution

Not obligatory, but suggest a fix/reason for the bug

@freaz freaz added the enhancement New feature or request label Aug 31, 2022
@freaz freaz assigned freaz and unassigned freaz Oct 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant