Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for multiple-element jQuery container at init (synced paginators) #52

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

edmundo096
Copy link

@edmundo096 edmundo096 commented Mar 2, 2018

Modified the logic that inserts the initial paginationjs element into the container, so that our model element jQuery sobject has a reference to multiple inserted paginationjs elements.
Whenever we make a change and listen to our model element jQuery object, it will be linked to our multiple elements (and thus, make them work in sync).

More testing should be made though.

@edmundo096 edmundo096 changed the title Add support for multiple-element jQuery container at init Add support for multiple-element jQuery container at init (synced paginators) Mar 2, 2018
Copy link

@sb84 sb84 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For proper work, remove the line:

  1. containerattributes.position === 'bottom' ? 'append' : 'prepend';

Then the code works properly, regardless of the number and location of elements on the page.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants