From 32b4f7660358e257eefb7f2d2f1dfcd8d3a60917 Mon Sep 17 00:00:00 2001 From: Nabil Freij Date: Fri, 8 Sep 2023 17:57:31 -0700 Subject: [PATCH] Apply suggestions from code review --- README.rst | 5 +++-- sunpy_soar/attrs.py | 1 + 2 files changed, 4 insertions(+), 2 deletions(-) diff --git a/README.rst b/README.rst index 75ed9ff..7c91c35 100644 --- a/README.rst +++ b/README.rst @@ -20,8 +20,9 @@ Installation ------------ **Note** + With the updates to the SOAR, the product names now need to be lowercase. -This is fixed with the latest release of sunpy-soar, so you may need to update if +This is fixed with the latest release of sunpy-soar, so you will need to update if you are having issues finding data. sunpy-soar requires `python >= 3.7` and `sunpy >= 2.1`. @@ -53,7 +54,7 @@ The code below gives an example of how to search and download Solar Orbiter data instrument = a.Instrument('EUI') time = a.Time('2021-02-01', '2021-02-02') level = a.Level(1) - product = a.soar.Product('eui-fsi174-image') + product = a.soar.Product('EUI-FSI174-IMAGE') # Do search result = Fido.search(instrument & time & level & product) diff --git a/sunpy_soar/attrs.py b/sunpy_soar/attrs.py index b00c48f..a18493b 100644 --- a/sunpy_soar/attrs.py +++ b/sunpy_soar/attrs.py @@ -10,6 +10,7 @@ class Product(SimpleAttr): """ The data product identifier to search for. + Makes the value passed lower so that it is case insensitive as all descriptors on the SOAR are now lowercase. """