Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run and fix online tests #143

Merged
merged 6 commits into from
Oct 29, 2024
Merged
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ jobs:
toxdeps: tox-pypi-filter
posargs: -n auto --dist loadgroup
envs: |
- linux: py311-devdeps
- linux: py312-online
secrets:
CODECOV_TOKEN: ${{ secrets.CODECOV_TOKEN }}

Expand Down
7 changes: 4 additions & 3 deletions pytest.ini
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ filterwarnings =
error
# Do not fail on pytest config issues (i.e. missing plugins) but do show them
always::pytest.PytestConfigWarning
# A list of warnings to ignore follows. If you add to this list, you MUST
# add a comment or ideally a link to an issue that explains why the warning
# is being ignored
# Zeep relies on deprecated cgi in Python 3.11
# Needs a release of zeep 4.2.2 or higher
# https://github.com/mvantellingen/python-zeep/pull/1364
ignore:'cgi' is deprecated and slated for removal in Python 3.13:DeprecationWarning
2 changes: 1 addition & 1 deletion sunkit_instruments/goes_xrs/goes_chianti_tem.py
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ def calculate_temperature_em(goes_ts, abundance="coronal"):
[
"https://sohoftp.nascom.nasa.gov/solarsoft/gen/idl/synoptic/goes/goes_chianti_response_latest.fits"
],
"4ca9730fb039e8a04407ae0aa4d5e3e2566b93dfe549157aa7c8fc3aa1e3e04d",
"cb00c05850e3dc3bbd856eb07c1a372758d689d0845ee591d6e2531afeab0382",
)
def _chianti_temp_emiss(
goes_ts, satellite_number, secondary=0, abundance="coronal", remove_scaling=False
Expand Down
3 changes: 2 additions & 1 deletion tox.ini
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ min_version = 4.0
requires =
tox-pypi-filter>=0.14
envlist =
py{310,311,312}
py{310,311,312}{,-online}
py312-devdeps
py310-oldestdeps
codestyle
Expand Down Expand Up @@ -68,6 +68,7 @@ commands =
--cov=sunkit_instruments \
--cov-config={toxinidir}/.coveragerc \
{toxinidir}/docs \
online: --remote-data=any \
{posargs}

[testenv:codestyle]
Expand Down
Loading