-
Notifications
You must be signed in to change notification settings - Fork 26
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Impossible to implement this SDK in any app (Nav bar color issues) #121
Comments
Same here, just adding the SumupSDK changes the navigation bar colors to white in the complete app, so they become white even in dark mode. I also think the SumUpSDK shouldn't touch UIAppearance at all. |
Same Problem here. Are there any suggestions? |
We've just released version 4.3.3, which contains a fix for this UIAppearance problem. Please let me know if this does not fix the issue for you. |
@jadeburton-sumup v4.3.3 does not fix the issue for me, after calling into Sumup (just logging in to show the list of payment methods and cancelling), the navigation bars become white in Dark Mode for the whole app. The bug only occurs for scrollable views in their scrolled-down state after the navigation bar changes from being inline to an overlay. |
Alright @ralfebert thanks for checking this. We will need more time to find the cause of this; the UIAppearance code we removed apparently wasn't it. |
Has this been fixed? I'm trying now to integrate into my taximeter app and don't see any UIAppearance effects from SumUp on my app. I'm having black UINavigationBars (UIKit), they stay black. |
Hi @staninprague, the last thing that changed in this area was in 4.3.3, and @ralfebert reported that it was not fixed in that version. I don't have a timeframe for a fix at this stage. |
The problem is that you are touching "appearance()" of entire UI of the app. This causes a lot of issue, some labels become invisible, navigation bar in dark mode becomes white and many other issue.
NEVER touch UI appearance! NEVER!
The text was updated successfully, but these errors were encountered: