Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Error if wrong grant_type #40

Open
gartner opened this issue Apr 9, 2023 · 1 comment
Open

Error if wrong grant_type #40

gartner opened this issue Apr 9, 2023 · 1 comment

Comments

@gartner
Copy link

gartner commented Apr 9, 2023

In setGrantType() method of class SumUp\Application\ApplicationConfiguration, if you pass an invalid granttype, an exception is thrown. But, you will get a TypeError instead of the expected exception, since the call to implode() is not valid for php 8:
The separator is passed after the array, which was only valid up until php 7.
gartner added a commit to gartner/sumup-ecom-php-sdk that referenced this issue Apr 9, 2023
@gartner
Fix sumup#40: Separator has to be first
be2a93d 
In php 8 the separator needs to be the first argument to implode() - in php 7 and earlier, it could be both first and last.
@multikitty
Copy link

Hi, gatner! Could you help me to solve #39 ?

@DiogoFilhoDeMorais DiogoFilhoDeMorais mentioned this issue Jun 13, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@gartner @multikitty