Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

show/hide intro on mobile #23

Closed
leekinney opened this issue Jul 23, 2014 · 7 comments
Closed

show/hide intro on mobile #23

leekinney opened this issue Jul 23, 2014 · 7 comments
Assignees

Comments

@leekinney
Copy link
Member

No description provided.

@leekinney leekinney self-assigned this Jul 23, 2014
@kongsally
Copy link

@leekinney I think this is similar to the issue I put up last night #21 . I had it fixed in my branch but it was behind versioning. I'll merge the one I was working on with the latest master branch and push it back up so you can see and maybe work around that. Thanks!

@leekinney
Copy link
Member Author

@kongsally We were thinking of doing a show/hide with the intro so you could hide the paragraph that explains the site and just have the search box to show more of the map and free up space. I think this is a different issue than what you were referencing in 21? Have you checked out our changes since last night? I think we were able to work through some of the layout issues. Do you think we could work with the current layout and make changes to that? Jim and I liked the draggable overlay option on desktop as it allows the map to span the entire screen. There were also a few changes I made to the styles and index dealing with some front-end accessibility issues in regards to screen readers so I don't want those to get overwritten. Thanks!

@kongsally
Copy link

The changes I made in my branch in the repo was from two weeks ago. I assumed everyone would be working on a separate branch then merging it to the master after we talked about it which is why I didn't merge it to the master branch. I should have issued a pull request and put up in the issue list before having things I've already worked on being redone by you. Sorry about that. But yes, I'll just edit from what we have now tonight.

I was also wondering why we would want the map to span the full screen because I think the message with the limited stations is equally important as the map. People won't immediately realize which stations are not limited based on just the x mark on the map but they would through the message pane. I also think it just looks too cluttered with multiple things overlaid (the description, the search bar and the list of limited stations). Moreover, even if there is a toggle option, people would still need to click it to see the map. Which is why I tried out this layout which I think is more organized the day after the girl develop it workshop two weeks ago: http://kongsally.github.io/wheel-chair-accessible-google-maps/ I do think a draggable div would be useful for a search bar overlaid on the map though, what do you think?

@leekinney
Copy link
Member Author

Adding show/hide as text to hopefully be unobtrusive but open to suggestions if someone thinks a button or something else might be better.

@jimRsmiley
Copy link

I think a smaller [ more ] or [ hide ] is worth trying.

@leekinney
Copy link
Member Author

Okay. Will do.

@jimRsmiley
Copy link

I think Sally's correct about the multiple windows in the map cluttering it. I've opened up Issue #31 to fix or discuss it. That's a good point that I lost in a larger conversation over layout. Let's keep discussions in issues centered on their specific resolution. Larger topics should be covered in person preferably before any work is done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants