Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Additional Webspaces Field to Settings Tab #213

Draft
wants to merge 2 commits into
base: 0.8
Choose a base branch
from

Conversation

alexander-schranz
Copy link
Member

@alexander-schranz alexander-schranz commented Oct 14, 2021

Most entities like Article and any routable Custom Entity will have a webspace selection in its settings tab. I did go here with the name WebspaceInterface.

The entity like Page will not implement it as the webspace will there not be on the PageDimensionContent Entity and so not implement for its webspace a content interface. Other entity like snippet which will have content will not have a Webspace field or relation.

TODO

  • Discuss how additionalWebspaces are saved
    • Version A: JSON Field (performant smart content query)
    • Version B: Additional Table with Webspace (primaryKey is webspaceKey)
    • Version C: Additional General Table (DimensionContentWebspace entity)
    • Version D: Additional Table without ORM (not sure if possible)

See prototype repository: alexander-schranz/doctrine-json-array-prototype#1

Keep in mind for navigationContexts we need something similar, but as they are Page specific and will not be part of the content bundle it is not as important as additionalWebspaces which will be used by any entity using content bundle with routing.

@alexander-schranz alexander-schranz added the Feature New functionality not yet included in Bundle label Oct 14, 2021
@coveralls
Copy link

coveralls commented Oct 14, 2021

Pull Request Test Coverage Report for Build 1343203423

  • 49 of 49 (100.0%) changed or added relevant lines in 5 files are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage remained the same at 100.0%

Totals Coverage Status
Change from base Build 1340881271: 0.0%
Covered Lines: 2058
Relevant Lines: 2058

💛 - Coveralls

@alexander-schranz alexander-schranz changed the title Add AdditionalWebspace Settings field Add Additional Webspace Field to Settings Tab Oct 14, 2021
@alexander-schranz alexander-schranz changed the title Add Additional Webspace Field to Settings Tab Add Additional Webspaces Field to Settings Tab Oct 14, 2021
Comment on lines +23 to +26
/**
* @var string[]|null
*/
protected $additionalWebspaces;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As discussed with @chirimoya we will go with a one-to-many relation.

The content bundle will provide also a AdditionalWebspaceTrait content bundle so a article bundle for example has then 3 entities:

Article
ArticleDimensionContent
ArticleDimensionContentWebspace

The ArticleDimensionContentWebspace will have id, dimensionContent and webspace field.

/cc @TheCadien do you want to have a look at this?

@TheCadien
Copy link
Member

TheCadien commented Apr 22, 2024

@alexander-schranz i do that

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Feature New functionality not yet included in Bundle
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants