-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Additional Webspaces Field to Settings Tab #213
base: 0.8
Are you sure you want to change the base?
Add Additional Webspaces Field to Settings Tab #213
Conversation
Pull Request Test Coverage Report for Build 1343203423
💛 - Coveralls |
874aa9b
to
1134821
Compare
/** | ||
* @var string[]|null | ||
*/ | ||
protected $additionalWebspaces; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As discussed with @chirimoya we will go with a one-to-many
relation.
The content bundle will provide also a AdditionalWebspaceTrait
content bundle so a article bundle for example has then 3 entities:
Article
ArticleDimensionContent
ArticleDimensionContentWebspace
The ArticleDimensionContentWebspace
will have id
, dimensionContent
and webspace
field.
/cc @TheCadien do you want to have a look at this?
@alexander-schranz i do that |
Most entities like
Article
and any routable Custom Entity will have a webspace selection in its settings tab. I did go here with the nameWebspaceInterface
.The entity like
Page
will not implement it as the webspace will there not be on the PageDimensionContent Entity and so not implement for its webspace a content interface. Other entity like snippet which will have content will not have a Webspace field or relation.TODO
additionalWebspaces
are savedwebspaceKey
)See prototype repository: alexander-schranz/doctrine-json-array-prototype#1
Keep in mind for
navigationContexts
we need something similar, but as they are Page specific and will not be part of the content bundle it is not as important asadditionalWebspaces
which will be used by any entity using content bundle with routing.