Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Active presence and Notes update #1522

Merged
merged 3 commits into from
Aug 10, 2023
Merged

Active presence and Notes update #1522

merged 3 commits into from
Aug 10, 2023

Conversation

Yessirskiy
Copy link
Contributor

Minor changes in PR:

  1. Fixed type hint of the recently added direct_message_search() (direct_message_search() method added #1521)
  2. Added Return description in direct_users_presence() (Updating direct and feed/reels methods #1482)
  3. Added creator_info() (probably, separated CreatorMixin needed as there are some more /creator/ methods unexplored)

Major changes done in NoteMixin and related:

  1. Removed NoteRequest and NoteResponse from types.py. Instead, left just Note class (status field removed as it's only received on creation, indicating success of the action).
  2. Remove extract_note() as not a single method requires an extractor.
  3. Removed uuid import, as no need in generating one for requesting.
  4. Added docs to every single method.
  5. Added response parsing: create_note(), get_notes() returning Note and List[Note]; delete_note() + last_seen_update_note() - bool
  6. last_seen_update_note() added.
  7. Renamed existing methods, previos naming didn't reflect the functionality and looked a bit ugly :) xD

@adw0rd adw0rd merged commit ead1adf into subzeroid:master Aug 10, 2023
5 of 9 checks passed
@adw0rd
Copy link
Contributor

adw0rd commented Aug 10, 2023

@Yessirskiy big thanks!

@adw0rd
Copy link
Contributor

adw0rd commented Aug 10, 2023

@Yessirskiy do you plan to add changes to the documentation?

@adw0rd
Copy link
Contributor

adw0rd commented Aug 10, 2023

Released instagrapi 1.19.3

@Yessirskiy
Copy link
Contributor Author

@Yessirskiy do you plan to add changes to the documentation?

Yeah, will do on weekends :)

@adw0rd
Copy link
Contributor

adw0rd commented Aug 10, 2023

@Yessirskiy thanks!

@adw0rd
Copy link
Contributor

adw0rd commented Aug 10, 2023

I just noticed such a PR, can you see what is useful there?

@Yessirskiy
Copy link
Contributor Author

I just noticed such a PR, can you see what is useful there?

Not much really, changed only docs, naming, but not functionality

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants