Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

proposed bundle limits #22

Merged
merged 7 commits into from
Oct 3, 2024
Merged

proposed bundle limits #22

merged 7 commits into from
Oct 3, 2024

Conversation

dariolina
Copy link
Member

as proposed in autonomys/subspace#2365

@dariolina dariolina requested a review from NingLin-P March 28, 2024 10:52
NingLin-P
NingLin-P approved these changes Mar 28, 2024
View reviewed changes
Copy link
Collaborator

@NingLin-P NingLin-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change make sense to me.

@NingLin-P NingLin-P mentioned this pull request Apr 1, 2024
Merged
1 task
@NingLin-P NingLin-P self-assigned this May 21, 2024
@dariolina dariolina requested a review from vedhavyas May 29, 2024 13:57
@dariolina dariolina mentioned this pull request May 30, 2024
Closed
@NingLin-P NingLin-P mentioned this pull request Oct 1, 2024
Merged
1 task
teor2345
teor2345 reviewed Oct 2, 2024
View reviewed changes
Copy link
Contributor

@teor2345 teor2345 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just some typos and grammar nitpicks

docs/decex/bundles_blocks.md Outdated Show resolved Hide resolved
docs/decex/bundles_blocks.md Outdated Show resolved Hide resolved
docs/decex/bundles_blocks.md Outdated Show resolved Hide resolved
docs/decex/interfaces.md Outdated Show resolved Hide resolved
docs/decex/workflow.md Outdated Show resolved Hide resolved
@dariolina dariolina marked this pull request as ready for review October 2, 2024 09:50
NingLin-P
NingLin-P reviewed Oct 2, 2024
View reviewed changes
Copy link
Collaborator

@NingLin-P NingLin-P left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, plz resolve the conflict

@dariolina dariolina merged commit bb660e4 into main Oct 3, 2024
@dariolina dariolina deleted the domain-config branch October 3, 2024 15:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NingLin-P NingLin-P NingLin-P approved these changes

@teor2345 teor2345 teor2345 left review comments

@vedhavyas vedhavyas Awaiting requested review from vedhavyas

Assignees

@NingLin-P NingLin-P

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dariolina @teor2345 @NingLin-P