-
Notifications
You must be signed in to change notification settings - Fork 334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fixed the issue where flags that require special handling were being overwritten. #2613
Conversation
…nvalid endpoint" error.
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
---|---|---|---|
🟡 | Statements | 67.16% (-2.95% 🔻) |
20474/30485 |
🟡 | Branches | 78.77% (+0.48% 🔼) |
2734/3471 |
🟡 | Functions | 69.33% (+6.83% 🔼) |
1135/1637 |
🟡 | Lines | 67.16% (-2.95% 🔻) |
20474/30485 |
Show new covered files 🐣
St.❔ |
File | Statements | Branches | Functions | Lines |
---|---|---|---|---|---|
🟢 | ... / migrate.ts |
85.34% | 16.67% | 100% | 85.34% |
🟢 | ... / migrate-abis.controller.ts |
95% | 87.5% | 100% | 95% |
🟢 | ... / constants.ts |
100% | 100% | 100% | 100% |
🟢 | ... / index.ts |
100% | 100% | 100% | 100% |
🟢 | ... / ethereum.ts |
82.28% | 83.33% | 100% | 82.28% |
🟢 | ... / migrate-manifest.controller.ts |
88% | 73.33% | 88.89% | 88% |
🟢 | ... / migrate-mapping.controller.ts |
100% | 100% | 100% | 100% |
🟢 | ... / migrate-controller.ts |
92.41% | 85.19% | 100% | 92.41% |
🟢 | ... / migrate.fixtures.ts |
100% | 100% | 100% | 100% |
🟢 | ... / migrate-schema.controller.ts |
97.23% | 79.49% | 100% | 97.23% |
🔴 | ... / types.ts |
0% | 0% | 0% | 0% |
🟢 | ... / createProject.fixtures.ts |
87.07% | 75% | 100% | 87.07% |
🟢 | ... / config.ts |
100% | 100% | 100% | 100% |
🟢 | ... / index.ts |
100% | 100% | 100% | 100% |
🔴 | ... / moduleLoader.ts |
56% | 40% | 100% | 56% |
🟢 | ... / types.ts |
100% | 100% | 100% | 100% |
🔴 | ... / utils.ts |
0% | 0% | 0% | 0% |
🟢 | ... / networkFamily.ts |
92.59% | 88.89% | 100% | 92.59% |
🟡 | ... / IPFSHTTPClientLite.ts |
75.74% | 80% | 88.89% | 75.74% |
🟢 | ... / index.ts |
100% | 100% | 100% | 100% |
🟢 | ... / utils.ts |
92% | 66.67% | 100% | 92% |
🟡 | ... / admin.controller.ts |
77.24% | 96.3% | 78.57% | 77.24% |
🔴 | ... / blockRange.ts |
46.67% | 100% | 50% | 46.67% |
🟢 | ... / index.ts |
100% | 100% | 100% | 100% |
🟢 | ... / SubqueryProject.ts |
85.52% | 83.33% | 71.43% | 85.52% |
🟢 | ... / core.module.ts |
100% | 100% | 100% | 100% |
🟢 | ... / dictionary.fixtures.ts |
100% | 100% | 100% | 100% |
🟢 | ... / monitor.service.ts |
94.4% | 87.36% | 97.06% | 94.4% |
🔴 | ... / sandbox.service.ts |
33.33% | 50% | 25% | 33.33% |
🟡 | ... / baseCache.service.ts |
62.12% | 88.89% | 66.67% | 62.12% |
🔴 | ... / baseStoreModel.service.ts |
57.41% | 66.67% | 80% | 57.41% |
🟢 | ... / cacheable.ts |
89.66% | 75% | 100% | 89.66% |
🟡 | ... / csvStore.service.ts |
77.78% | 80% | 80% | 77.78% |
🟢 | ... / index.ts |
100% | 100% | 100% | 100% |
🟡 | ... / cacheMetadata.ts |
62.11% | 72.5% | 86.67% | 62.11% |
🟢 | ... / index.ts |
100% | 100% | 100% | 100% |
🔴 | ... / metadata.ts |
53.01% | 71.43% | 55.56% | 53.01% |
🟢 | ... / utils.ts |
100% | 100% | 100% | 100% |
🟢 | ... / cacheModel.ts |
86.33% | 83.12% | 85% | 86.33% |
🟢 | ... / index.ts |
100% | 100% | 100% | 100% |
🟡 | ... / model.ts |
77.36% | 73.91% | 81.82% | 77.36% |
🟢 | ... / utils.ts |
100% | 100% | 100% | 100% |
🟡 | ... / cachePoi.ts |
76.84% | 89.47% | 85.71% | 76.84% |
🟢 | ... / index.ts |
100% | 100% | 100% | 100% |
🔴 | ... / poi.ts |
41.07% | 71.43% | 44.44% | 41.07% |
🟢 | ... / setValueModel.ts |
82.05% | 79.41% | 85.71% | 82.05% |
🟡 | ... / storeCache.service.ts |
63.35% | 84.38% | 73.33% | 63.35% |
🔴 | ... / storeModel.service.ts |
56.79% | 50% | 57.14% | 56.79% |
🟢 | ... / types.ts |
100% | 100% | 100% | 100% |
🟢 | ... / utils.ts |
93.75% | 66.67% | 100% | 93.75% |
🟢 | ... / worker.core.module.ts |
100% | 100% | 0% | 100% |
🔴 | ... / worker.monitor.service.ts |
39.53% | 100% | 0% | 39.53% |
🔴 | ... / meta.controller.ts |
53.33% | 100% | 0% | 53.33% |
🟡 | ... / meta.module.ts |
60% | 100% | 0% | 60% |
🟡 | ... / process.ts |
61.29% | 66.67% | 40% | 61.29% |
🔴 | ... / foreceClean.init.ts |
47.62% | 100% | 0% | 47.62% |
🔴 | ... / reindex.init.ts |
33.33% | 100% | 0% | 33.33% |
🟢 | ... / string.ts |
100% | 100% | 100% | 100% |
🔴 | ... / datasourceProcessors.ts |
0% | 0% | 0% | 0% |
🔴 | ... / index.ts |
0% | 0% | 0% | 0% |
🔴 | ... / types.ts |
0% | 0% | 0% | 0% |
🔴 | ... / networking.ts |
31.58% | 100% | 0% | 31.58% |
Show files with reduced coverage 🔻
St.❔ |
File | Statements | Branches | Functions | Lines |
---|---|---|---|---|---|
🔴 | ... / delete.ts |
48.72% (-5.57% 🔻) |
100% | 50% (+50% 🔼) |
48.72% (-5.57% 🔻) |
🔴 | ... / promote.ts |
44.19% (-4.53% 🔻) |
100% | 50% (+50% 🔼) |
44.19% (-4.53% 🔻) |
🟡 | ... / add.ts |
61.29% (-0.78% 🔻) |
100% | 50% (+50% 🔼) |
61.29% (-0.78% 🔻) |
🟢 | ... / publish.ts |
83.72% (-5.61% 🔻) |
60% (+2.86% 🔼) |
100% | 83.72% (-5.61% 🔻) |
🔴 | ... / add-chain-controller.ts |
39.62% (-0.45% 🔻) |
66.67% | 30% | 39.62% (-0.45% 🔻) |
🟢 | ... / build-controller.ts |
89.71% (-1.6% 🔻) |
66.67% (+9.52% 🔼) |
100% | 89.71% (-1.6% 🔻) |
🟢 | ... / codegen-controller.ts |
88.52% (-0.86% 🔻) |
85.9% (+10.32% 🔼) |
100% | 88.52% (-0.86% 🔻) |
🟡 | ... / deploy-controller.ts |
64.94% (+27.48% 🔼) |
72.73% (-5.05% 🔻) |
64.29% (+39.29% 🔼) |
64.94% (+27.48% 🔼) |
🟢 | ... / generate-controller.ts |
97.75% (+0.1% 🔼) |
93.24% (-0.79% 🔻) |
100% | 97.75% (+0.1% 🔼) |
🟡 | ... / init-controller.ts |
73.06% (+2.57% 🔼) |
54.55% (-13.45% 🔻) |
61.11% (+7.78% 🔼) |
73.06% (+2.57% 🔼) |
🟢 | ... / project-controller.ts |
83.13% (-14.13% 🔻) |
42.86% (-17.14% 🔻) |
75% (-25% 🔻) |
83.13% (-14.13% 🔻) |
🟡 | ... / publish-controller.ts |
78.39% (-1.86% 🔻) |
63.64% (-7.47% 🔻) |
83.33% (-16.67% 🔻) |
78.39% (-1.86% 🔻) |
🔴 | ... / models.ts |
50% (-49.44% 🔻) |
94.12% (+1.81% 🔼) |
30.77% (-69.23% 🔻) |
50% (-49.44% 🔻) |
🟢 | ... / model.ts |
93.14% (-4.57% 🔻) |
100% | 73.33% (+1.9% 🔼) |
93.14% (-4.57% 🔻) |
🔴 | ... / models.ts |
47.06% (-52.94% 🔻) |
100% | 0% (-100% 🔻) |
47.06% (-52.94% 🔻) |
🟡 | ... / load.ts |
64.29% (+5.1% 🔼) |
38.89% (-16.67% 🔻) |
83.33% (+16.67% 🔼) |
64.29% (+5.1% 🔼) |
🟡 | ... / github-reader.ts |
65.52% (-23.77% 🔻) |
85.71% (+10.71% 🔼) |
71.43% (-11.9% 🔻) |
65.52% (-23.77% 🔻) |
🟡 | ... / ipfs-reader.ts |
61.9% (-23.81% 🔻) |
72.73% (+9.09% 🔼) |
71.43% (-11.9% 🔻) |
61.9% (-23.81% 🔻) |
🟡 | ... / local-reader.ts |
67.5% (-18.55% 🔻) |
100% (+37.5% 🔼) |
83.33% (-16.67% 🔻) |
67.5% (-18.55% 🔻) |
🟢 | ... / reader.ts |
81.58% (-7.89% 🔻) |
50% (-25% 🔻) |
100% | 81.58% (-7.89% 🔻) |
🟡 | ... / utils.ts |
73.05% (+10.34% 🔼) |
72.73% (-0.44% 🔻) |
65.38% (+9.38% 🔼) |
73.05% (+10.34% 🔼) |
🔴 | ... / base.ts |
45.79% (-52.21% 🔻) |
100% | 40% (-40% 🔻) |
45.79% (-52.21% 🔻) |
🔴 | ... / models.ts |
26.35% (-73.65% 🔻) |
100% | 0% (-100% 🔻) |
26.35% (-73.65% 🔻) |
🟢 | ... / NodeConfig.ts |
88.51% (-0.1% 🔻) |
79.03% (-0.6% 🔻) |
85.11% (-0.94% 🔻) |
88.51% (-0.1% 🔻) |
🟡 | ... / ProjectUpgrade.service.ts |
75.32% (-11.76% 🔻) |
71.25% (-20.11% 🔻) |
92.31% (+1% 🔼) |
75.32% (-11.76% 🔻) |
🟢 | ... / configure.module.ts |
82.67% (-1.9% 🔻) |
71.15% (+7.15% 🔼) |
100% | 82.67% (-1.9% 🔻) |
🟢 | ... / db.module.ts |
89.06% (+0.78% 🔼) |
62.5% (-20.83% 🔻) |
80% | 89.06% (+0.78% 🔼) |
🟢 | ... / SchemaMigration.service.ts |
84.04% (-3.52% 🔻) |
78.13% (-3.13% 🔻) |
83.33% (-16.67% 🔻) |
84.04% (-3.52% 🔻) |
🟡 | ... / migration-helpers.ts |
75.28% (-0.74% 🔻) |
88.24% (+7.64% 🔼) |
90.91% | 75.28% (-0.74% 🔻) |
🟡 | ... / migration.ts |
73.29% (-9% 🔻) |
83.33% (+3.6% 🔼) |
85% (-5.48% 🔻) |
73.29% (-9% 🔻) |
🟡 | ... / StoreOperations.ts |
65.88% (-26.43% 🔻) |
60% (-25% 🔻) |
87.5% (-12.5% 🔻) |
65.88% (-26.43% 🔻) |
🔴 | ... / benchmark.service.ts |
43.36% (-11.89% 🔻) |
66.67% | 36.36% (-3.64% 🔻) |
43.36% (-11.89% 🔻) |
🔴 | ... / base-block-dispatcher.ts |
18.33% (-29.02% 🔻) |
100% | 4.35% (-5.65% 🔻) |
18.33% (-29.02% 🔻) |
🔴 | ... / block-dispatcher.ts |
26.61% (-14.39% 🔻) |
66.67% | 25% (-3.57% 🔻) |
26.61% (-14.39% 🔻) |
🔴 | ... / worker-block-dispatcher.ts |
36.17% (-14.04% 🔻) |
100% | 25% (-2.27% 🔻) |
36.17% (-14.04% 🔻) |
🟢 | ... / coreDictionary.ts |
94.67% (-5.33% 🔻) |
88.24% (-6.21% 🔻) |
88.89% (-11.11% 🔻) |
94.67% (-5.33% 🔻) |
🟡 | ... / dictionary.service.ts |
68.47% (-16.67% 🔻) |
83.78% (-1.93% 🔻) |
83.33% (-7.58% 🔻) |
68.47% (-16.67% 🔻) |
🟢 | ... / dictionaryV1.ts |
89.8% (-3.43% 🔻) |
75.56% (-2.71% 🔻) |
100% | 89.8% (-3.43% 🔻) |
🟡 | ... / dictionaryV2.ts |
67.37% (-14.31% 🔻) |
68% (+2.78% 🔼) |
88.89% (-11.11% 🔻) |
67.37% (-14.31% 🔻) |
🔴 | ... / ds-processor.service.ts |
38.12% (-23.97% 🔻) |
75% | 58.33% (-29.17% 🔻) |
38.12% (-23.97% 🔻) |
🟡 | ... / dynamic-ds.service.ts |
60.16% (-30.04% 🔻) |
65% (-1.67% 🔻) |
80% (-5.71% 🔻) |
60.16% (-30.04% 🔻) |
🟢 | ... / fetch.service.ts |
92.23% (-0.06% 🔻) |
87.67% (-1.06% 🔻) |
88% (+1.04% 🔼) |
92.23% (-0.06% 🔻) |
🟢 | ... / inMemoryCache.service.ts |
86.21% (-13.79% 🔻) |
100% | 75% (-25% 🔻) |
86.21% (-13.79% 🔻) |
🔴 | ... / indexer.manager.ts |
16.79% (-16.42% 🔻) |
100% | 10% (-2.5% 🔻) |
16.79% (-16.42% 🔻) |
🟢 | ... / PoiBlock.ts |
83.87% (-14.52% 🔻) |
96.55% | 75% (-25% 🔻) |
83.87% (-14.52% 🔻) |
🔴 | ... / poi.service.ts |
55.7% (+31.78% 🔼) |
57.69% (-42.31% 🔻) |
80% (+51.43% 🔼) |
55.7% (+31.78% 🔼) |
🔴 | ... / poiSync.service.ts |
55.88% (-31% 🔻) |
77.61% (+1.05% 🔼) |
88.89% (-3.42% 🔻) |
55.88% (-31% 🔻) |
🟡 | ... / project.service.ts |
69.58% (-10.42% 🔻) |
67.14% (-3.03% 🔻) |
85.19% (+1.19% 🔼) |
69.58% (-10.42% 🔻) |
🔴 | ... / sandbox.ts |
42.27% (-25.71% 🔻) |
62.5% (+5.36% 🔼) |
28.57% (-32.97% 🔻) |
42.27% (-25.71% 🔻) |
🔴 | ... / smartBatch.service.ts |
10.43% (-13.91% 🔻) |
100% | 12.5% (-1.79% 🔻) |
10.43% (-13.91% 🔻) |
🔴 | ... / entity.ts |
50% (-11.54% 🔻) |
100% | 50% (+50% 🔼) |
50% (-11.54% 🔻) |
🔴 | ... / store.ts |
30% (-2.2% 🔻) |
62.5% (-37.5% 🔻) |
33.33% (+33.33% 🔼) |
30% (-2.2% 🔻) |
🟢 | ... / test.runner.ts |
95.06% (-4.27% 🔻) |
77.78% (+4.44% 🔼) |
75% (-25% 🔻) |
95.06% (-4.27% 🔻) |
🔴 | ... / testing.service.ts |
12% (-16.57% 🔻) |
100% | 0% | 12% (-16.57% 🔻) |
🔴 | ... / unfinalizedBlocks.service.ts |
55.59% (-28.4% 🔻) |
72.55% (-24.17% 🔻) |
92% (+0.33% 🔼) |
55.59% (-28.4% 🔻) |
🔴 | ... / worker.builder.ts |
59.83% (-19.36% 🔻) |
65.38% | 80% | 59.83% (-19.36% 🔻) |
🔴 | ... / worker.cache.service.ts |
48.78% (-9.76% 🔻) |
100% | 0% | 48.78% (-9.76% 🔻) |
🔴 | ... / worker.connectionPoolState.manager.ts |
38.21% (-22.76% 🔻) |
100% | 0% | 38.21% (-22.76% 🔻) |
🔴 | ... / worker.dynamic-ds.service.ts |
44.44% (-17.78% 🔻) |
100% | 0% | 44.44% (-17.78% 🔻) |
🔴 | ... / worker.service.ts |
20.54% (-24.11% 🔻) |
100% | 0% | 20.54% (-24.11% 🔻) |
🔴 | ... / worker.ts |
42.08% (-0.37% 🔻) |
100% | 0% | 42.08% (-0.37% 🔻) |
🔴 | ... / worker.unfinalizedBlocks.service.ts |
26.79% (-73.21% 🔻) |
100% | 0% (-100% 🔻) |
26.79% (-73.21% 🔻) |
🔴 | ... / logger.ts |
47.89% (-16.59% 🔻) |
33.33% | 40% (+20% 🔼) |
47.89% (-16.59% 🔻) |
🔴 | ... / event.listener.ts |
15.15% (-65.66% 🔻) |
100% | 0% (-25% 🔻) |
15.15% (-65.66% 🔻) |
🔴 | ... / health.controller.ts |
37.93% (-17.24% 🔻) |
100% | 0% (-50% 🔻) |
37.93% (-17.24% 🔻) |
🔴 | ... / health.service.ts |
21.05% (-36.48% 🔻) |
100% | 0% (-20% 🔻) |
21.05% (-36.48% 🔻) |
🔴 | ... / meta.service.ts |
34.26% (-35.26% 🔻) |
100% (+20% 🔼) |
0% (-40% 🔻) |
34.26% (-35.26% 🔻) |
🔴 | ... / ready.controller.ts |
34.78% (-21.74% 🔻) |
100% | 0% (-50% 🔻) |
34.78% (-21.74% 🔻) |
🔴 | ... / ready.service.ts |
37.5% (-54.17% 🔻) |
100% | 0% (-66.67% 🔻) |
37.5% (-54.17% 🔻) |
🔴 | ... / forceClean.service.ts |
22.08% (-4.24% 🔻) |
100% | 0% | 22.08% (-4.24% 🔻) |
🔴 | ... / reindex.service.ts |
18.62% (-14.71% 🔻) |
100% | 0% | 18.62% (-14.71% 🔻) |
🔴 | ... / autoQueue.ts |
59.49% (-28.9% 🔻) |
85.11% | 70.37% (-8.8% 🔻) |
59.49% (-28.9% 🔻) |
🟡 | ... / blocks.ts |
71.21% (-28.79% 🔻) |
91.67% (+2.78% 🔼) |
75% (-25% 🔻) |
71.21% (-28.79% 🔻) |
🟡 | ... / project.ts |
71.88% (-1.49% 🔻) |
75% (+0.42% 🔼) |
77.78% | 71.88% (-1.49% 🔻) |
🟢 | ... / promise.ts |
86.44% (-5.32% 🔻) |
100% (+13.64% 🔼) |
71.43% (-14.29% 🔻) |
86.44% (-5.32% 🔻) |
🟢 | ... / reindex.ts |
82.05% (+48.01% 🔼) |
14.29% (-85.71% 🔻) |
100% (+100% 🔼) |
82.05% (+48.01% 🔼) |
🔴 | ... / yargs.ts |
40.69% (-4.8% 🔻) |
100% | 14.29% | 40.69% (-4.8% 🔻) |
🟢 | ... / apiPromise.connection.ts |
80% (+10.92% 🔼) |
61.54% (-18.46% 🔻) |
66.67% (+23.81% 🔼) |
80% (+10.92% 🔼) |
🟡 | ... / block-dispatcher.service.ts |
66.35% (-2.52% 🔻) |
100% | 33.33% (+8.33% 🔼) |
66.35% (-2.52% 🔻) |
🔴 | ... / worker-block-dispatcher.service.ts |
24.16% (-12.8% 🔻) |
0% (-100% 🔻) |
0% | 24.16% (-12.8% 🔻) |
🟢 | ... / substrateDictionary.service.ts |
98.11% (+7.55% 🔼) |
66.67% (-6.06% 🔻) |
100% (+20% 🔼) |
98.11% (+7.55% 🔼) |
🟢 | ... / substrateDictionaryV1.ts |
85.19% (-0.3% 🔻) |
78.72% (+8.96% 🔼) |
84.62% (+1.28% 🔼) |
85.19% (-0.3% 🔻) |
🟡 | ... / substrateDictionaryV2.ts |
73.03% (-2.48% 🔻) |
75% | 33.33% | 73.03% (-2.48% 🔻) |
🟢 | ... / fetch.module.ts |
89.6% (-2.27% 🔻) |
50% (-25% 🔻) |
100% | 89.6% (-2.27% 🔻) |
🔴 | ... / indexer.manager.ts |
50% (-7.55% 🔻) |
100% | 20% (+10.91% 🔼) |
50% (-7.55% 🔻) |
🟡 | ... / base-runtime.service.ts |
72.17% (-0.15% 🔻) |
76.92% (+1.92% 🔼) |
77.78% (+2.78% 🔼) |
72.17% (-0.15% 🔻) |
🟢 | ... / runtimeService.ts |
94.52% (+2.31% 🔼) |
81.82% (-7.07% 🔻) |
100% (+20% 🔼) |
94.52% (+2.31% 🔼) |
🟢 | ... / unfinalizedBlocks.service.ts |
85.45% (-0.82% 🔻) |
100% | 60% (+10% 🔼) |
85.45% (-0.82% 🔻) |
🔴 | ... / http.ts |
50.58% (-29.34% 🔻) |
50% (+10% 🔼) |
42.86% (+12.09% 🔼) |
50.58% (-29.34% 🔻) |
🟢 | ... / project.ts |
88.73% (-0.16% 🔻) |
68.18% | 87.5% | 88.73% (-0.16% 🔻) |
🟢 | ... / buffer.ts |
90.24% (-9.76% 🔻) |
91.3% (-8.7% 🔻) |
90.48% (+6.27% 🔼) |
90.24% (-9.76% 🔻) |
🟡 | ... / logger.ts |
69.19% (-0.41% 🔻) |
48.15% (-6.85% 🔻) |
78.57% (+3.57% 🔼) |
69.19% (-0.41% 🔻) |
Test suite run failed
Failed tests: 5/599. Failed suites: 3/107.
● AutoQueue › resumes after flushing
expect(received).toEqual(expected) // deep equality
- Expected - 0
+ Received + 2
@@ -1,8 +1,10 @@
Array [
1,
2,
+ 3,
+ 4,
11,
12,
13,
14,
15,
192 | );
193 |
> 194 | expect(results).toEqual([1, 2, 11, 12, 13, 14, 15, 16, 17, 18, 19, 20]);
| ^
195 | });
196 | });
197 |
at Object.<anonymous> (packages/node-core/src/utils/autoQueue.spec.ts:194:21)
● Test suite failed to run
TypeError: Class extends value undefined is not a constructor or null
84 | }
85 |
> 86 | class DsPluginSandbox<P> extends Sandbox {
| ^
87 | constructor(option: Omit<SandboxOption, 'store'>, nodeConfig: NodeConfig) {
88 | super(
89 | option,
at Object.<anonymous> (packages/node-core/src/indexer/ds-processor.service.ts:86:34)
at Object.<anonymous> (packages/node-core/src/indexer/indexer.manager.ts:13:1)
at Object.<anonymous> (packages/node-core/src/indexer/index.ts:23:1)
at Object.<anonymous> (packages/node-core/src/db/migration-service/SchemaMigration.service.ts:8:1)
at Object.<anonymous> (packages/node-core/src/db/migration-service/index.ts:5:1)
at Object.<anonymous> (packages/node-core/src/db/index.ts:5:1)
at Object.<anonymous> (packages/node-core/src/utils/graphql.ts:19:1)
at Object.<anonymous> (packages/node-core/src/utils/index.ts:7:1)
at Object.<anonymous> (packages/node-core/src/indexer/sandbox.ts:14:1)
at Object.<anonymous> (packages/node-core/src/indexer/sandbox.spec.ts:6:1)
● Cli publish › should upload appropriate project to IPFS
[tsl] ERROR in /tmp/Sl6mdw/multi_mocked_starter/src/types/models/ClaimRecord.ts(75,48)
TS2558: Expected 0 type arguments, but got 1.
[tsl] ERROR in /tmp/Sl6mdw/multi_mocked_starter/src/types/models/ClaimRecord.ts(81,48)
TS2558: Expected 0 type arguments, but got 1.
[tsl] ERROR in /tmp/Sl6mdw/multi_mocked_starter/src/types/models/ForgeRecord.ts(81,48)
TS2558: Expected 0 type arguments, but got 1.
[tsl] ERROR in /tmp/Sl6mdw/multi_mocked_starter/src/types/models/ForgeRecord.ts(87,48)
TS2558: Expected 0 type arguments, but got 1.
[tsl] ERROR in /tmp/Sl6mdw/multi_mocked_starter/src/types/models/NFT.ts(63,48)
TS2558: Expected 0 type arguments, but got 1.
[tsl] ERROR in /tmp/Sl6mdw/multi_mocked_starter/src/types/models/NFT.ts(69,48)
TS2558: Expected 0 type arguments, but got 1.
44 | const outputDir = path.resolve(directory, flags.output ?? 'dist');
45 |
> 46 | await runWebpack(buildEntries, directory, outputDir, isDev, true);
| ^
47 | if (!flags.silent) {
48 | this.log('Building and packing code ...');
49 | this.log('Done!');
at Object.error (node_modules/@oclif/core/lib/errors/index.js:27:15)
at Build.error (node_modules/@oclif/core/lib/command.js:139:23)
at Build.run (packages/cli/src/commands/build/index.ts:46:18)
at async Build._run (node_modules/@oclif/core/lib/command.js:117:22)
at async createMultiChainTestProject (packages/cli/src/createProject.fixtures.ts:89:5)
at async Promise.all (index 1)
at async Object.<anonymous> (packages/cli/src/controller/publish-controller.spec.ts:18:21)
● Cli publish › convert to deployment and removed descriptive field
[tsl] ERROR in /tmp/Sl6mdw/multi_mocked_starter/src/types/models/ClaimRecord.ts(75,48)
TS2558: Expected 0 type arguments, but got 1.
[tsl] ERROR in /tmp/Sl6mdw/multi_mocked_starter/src/types/models/ClaimRecord.ts(81,48)
TS2558: Expected 0 type arguments, but got 1.
[tsl] ERROR in /tmp/Sl6mdw/multi_mocked_starter/src/types/models/ForgeRecord.ts(81,48)
TS2558: Expected 0 type arguments, but got 1.
[tsl] ERROR in /tmp/Sl6mdw/multi_mocked_starter/src/types/models/ForgeRecord.ts(87,48)
TS2558: Expected 0 type arguments, but got 1.
[tsl] ERROR in /tmp/Sl6mdw/multi_mocked_starter/src/types/models/NFT.ts(63,48)
TS2558: Expected 0 type arguments, but got 1.
[tsl] ERROR in /tmp/Sl6mdw/multi_mocked_starter/src/types/models/NFT.ts(69,48)
TS2558: Expected 0 type arguments, but got 1.
44 | const outputDir = path.resolve(directory, flags.output ?? 'dist');
45 |
> 46 | await runWebpack(buildEntries, directory, outputDir, isDev, true);
| ^
47 | if (!flags.silent) {
48 | this.log('Building and packing code ...');
49 | this.log('Done!');
at Object.error (node_modules/@oclif/core/lib/errors/index.js:27:15)
at Build.error (node_modules/@oclif/core/lib/command.js:139:23)
at Build.run (packages/cli/src/commands/build/index.ts:46:18)
at async Build._run (node_modules/@oclif/core/lib/command.js:117:22)
at async createMultiChainTestProject (packages/cli/src/createProject.fixtures.ts:89:5)
at async Promise.all (index 1)
at async Object.<anonymous> (packages/cli/src/controller/publish-controller.spec.ts:18:21)
● Cli publish › convert js object to JSON object
[tsl] ERROR in /tmp/Sl6mdw/multi_mocked_starter/src/types/models/ClaimRecord.ts(75,48)
TS2558: Expected 0 type arguments, but got 1.
[tsl] ERROR in /tmp/Sl6mdw/multi_mocked_starter/src/types/models/ClaimRecord.ts(81,48)
TS2558: Expected 0 type arguments, but got 1.
[tsl] ERROR in /tmp/Sl6mdw/multi_mocked_starter/src/types/models/ForgeRecord.ts(81,48)
TS2558: Expected 0 type arguments, but got 1.
[tsl] ERROR in /tmp/Sl6mdw/multi_mocked_starter/src/types/models/ForgeRecord.ts(87,48)
TS2558: Expected 0 type arguments, but got 1.
[tsl] ERROR in /tmp/Sl6mdw/multi_mocked_starter/src/types/models/NFT.ts(63,48)
TS2558: Expected 0 type arguments, but got 1.
[tsl] ERROR in /tmp/Sl6mdw/multi_mocked_starter/src/types/models/NFT.ts(69,48)
TS2558: Expected 0 type arguments, but got 1.
44 | const outputDir = path.resolve(directory, flags.output ?? 'dist');
45 |
> 46 | await runWebpack(buildEntries, directory, outputDir, isDev, true);
| ^
47 | if (!flags.silent) {
48 | this.log('Building and packing code ...');
49 | this.log('Done!');
at Object.error (node_modules/@oclif/core/lib/errors/index.js:27:15)
at Build.error (node_modules/@oclif/core/lib/command.js:139:23)
at Build.run (packages/cli/src/commands/build/index.ts:46:18)
at async Build._run (node_modules/@oclif/core/lib/command.js:117:22)
at async createMultiChainTestProject (packages/cli/src/createProject.fixtures.ts:89:5)
at async Promise.all (index 1)
at async Object.<anonymous> (packages/cli/src/controller/publish-controller.spec.ts:18:21)
● Cli publish › Get directory CID from multi-chain project
[tsl] ERROR in /tmp/Sl6mdw/multi_mocked_starter/src/types/models/ClaimRecord.ts(75,48)
TS2558: Expected 0 type arguments, but got 1.
[tsl] ERROR in /tmp/Sl6mdw/multi_mocked_starter/src/types/models/ClaimRecord.ts(81,48)
TS2558: Expected 0 type arguments, but got 1.
[tsl] ERROR in /tmp/Sl6mdw/multi_mocked_starter/src/types/models/ForgeRecord.ts(81,48)
TS2558: Expected 0 type arguments, but got 1.
[tsl] ERROR in /tmp/Sl6mdw/multi_mocked_starter/src/types/models/ForgeRecord.ts(87,48)
TS2558: Expected 0 type arguments, but got 1.
[tsl] ERROR in /tmp/Sl6mdw/multi_mocked_starter/src/types/models/NFT.ts(63,48)
TS2558: Expected 0 type arguments, but got 1.
[tsl] ERROR in /tmp/Sl6mdw/multi_mocked_starter/src/types/models/NFT.ts(69,48)
TS2558: Expected 0 type arguments, but got 1.
44 | const outputDir = path.resolve(directory, flags.output ?? 'dist');
45 |
> 46 | await runWebpack(buildEntries, directory, outputDir, isDev, true);
| ^
47 | if (!flags.silent) {
48 | this.log('Building and packing code ...');
49 | this.log('Done!');
at Object.error (node_modules/@oclif/core/lib/errors/index.js:27:15)
at Build.error (node_modules/@oclif/core/lib/command.js:139:23)
at Build.run (packages/cli/src/commands/build/index.ts:46:18)
at async Build._run (node_modules/@oclif/core/lib/command.js:117:22)
at async createMultiChainTestProject (packages/cli/src/createProject.fixtures.ts:89:5)
at async Promise.all (index 1)
at async Object.<anonymous> (packages/cli/src/controller/publish-controller.spec.ts:18:21)
Report generated by 🧪jest coverage report action from c87544a
@@ -93,7 +93,9 @@ describe('Configure', () => { | |||
const option = {headers: {'api-key': '<your-api-key>'}}; | |||
const {primaryNetworkEndpoint} = yargsToIConfig({ | |||
'primary-network-endpoint': 'https://example.com', | |||
primaryNetworkEndpoint: 'https://example.com', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think this is a sufficient test. The issue was the snake case being overwritten not support for snakeCase
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The fields we get from yargs will include both snake_case and camelCase.
@@ -52,7 +52,7 @@ export function yargsToIConfig(yargs: Args, nameMapping: Record<string, string> | |||
return Object.entries(yargs).reduce((acc, [key, value]) => { | |||
if (['_', '$0'].includes(key)) return acc; | |||
|
|||
if (key === 'network-registry') { | |||
if (isMatchFlag(key, ['network-registry'])) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This fix is prone to the same error occuring again. If another flag is added and there is now implicit behaviour as to what this does the same issue could be introduced again with another flag.
I think it would be better to not compare using key and instead use the modified key (nameMapping[key] ?? camelCase(key)
)
Can you please update the PR description and name to describe the fix/cause not the symptom of the bug. I had to debug this myself because there is no explanation and the changes didn't make sense to how it could fix the bug |
primary-network-endpoint
flag
Description
When the
primary-network-endpoint
flag exists, it will report an "Invalid endpoint" error.After yargs parses the flags, there will be two types of fields: snake_case and camelCase. Therefore, we currently need to optimize the logic for handling camelCase fields.
Fixes #2612
Type of change
Please delete options that are not relevant.
Checklist