New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Unused value of "mu" #5

Open

catherio opened this issue May 9, 2018 · 1 comment

catherio commented May 9, 2018

glicko2/glicko2.py

Line 151 in 4a3078e

mu = rating.mu + Q / denom * (difference / variance_inv)

The value of "mu" at this line appears to be unused. Is this an error, or is it intentional?

Contributor

drdarina commented Oct 7, 2019

Looking at the paper, it is an error. The mu computed later is correct.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment