Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Why does reduce_impact not account for both teams' Phi values? #2

Open
ReagentX opened this issue Oct 25, 2017 · 1 comment
Open

Why does reduce_impact not account for both teams' Phi values? #2

ReagentX opened this issue Oct 25, 2017 · 1 comment

Comments

@ReagentX
Copy link

ReagentX commented Oct 25, 2017 •
edited
Loading

Why not add this on line 79?

phi = math.sqrt(team_1.phi ** 2 + team_2.phi ** 2)
@drdarina
Copy link
Contributor

drdarina commented Oct 7, 2019

Why do you think that's reasonable? He's following the original algorithm as published by Mark Glickman, so g(phi) is a function only of the opponent's rating deviation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ReagentX @drdarina