You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This is not correct because there's no guarantee that is same chapter that was downloaded, in fact if you click on download and switch chapter immediately the chapter download is the previous one but the name refers to the current one.
It would be better to save the name of the chapter being downloaded in the local function of the Download manager and pass it as an argument to initiateDownload function, that way would keep the correct name even if the chapter is changed in the UI.
The text was updated successfully, but these errors were encountered:
Apologies for being so late.
This was actually fixed with 8185ab7 but wasn't deployed until recently due to unforeseen circumstances. I'll leave this issue open for a while in case something goes awry.
The download system uses the current chapter for naming the file
https://github.com/appu1232/guyamoe/blob/4f9606bcfdbabc9da0c06755ea7ee5de861d3041/reader/static/js/init.js#L3607
This is not correct because there's no guarantee that is same chapter that was downloaded, in fact if you click on download and switch chapter immediately the chapter download is the previous one but the name refers to the current one.
It would be better to save the name of the chapter being downloaded in the local function of the Download manager and pass it as an argument to initiateDownload function, that way would keep the correct name even if the chapter is changed in the UI.
The text was updated successfully, but these errors were encountered: