Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Download chapter naming bug when switching chapter #108

Open
Sapo84 opened this issue Jul 9, 2021 · 2 comments
Open

Download chapter naming bug when switching chapter #108

Sapo84 opened this issue Jul 9, 2021 · 2 comments

Comments

@Sapo84
Copy link

Sapo84 commented Jul 9, 2021

The download system uses the current chapter for naming the file
https://github.com/appu1232/guyamoe/blob/4f9606bcfdbabc9da0c06755ea7ee5de861d3041/reader/static/js/init.js#L3607

This is not correct because there's no guarantee that is same chapter that was downloaded, in fact if you click on download and switch chapter immediately the chapter download is the previous one but the name refers to the current one.
It would be better to save the name of the chapter being downloaded in the local function of the Download manager and pass it as an argument to initiateDownload function, that way would keep the correct name even if the chapter is changed in the UI.

@Algoinde
Copy link
Member

Algoinde commented Jul 9, 2021

Wait that's hilarious. I should have actually reviewed the download feature pull request, will fix soon

@Einlion
Copy link
Collaborator

Einlion commented Aug 28, 2021

Apologies for being so late.
This was actually fixed with 8185ab7 but wasn't deployed until recently due to unforeseen circumstances. I'll leave this issue open for a while in case something goes awry.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants