Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

hashtag ligature (##) with problems in kitty terminal #141

Open
Ordeeper opened this issue Nov 16, 2023 · 30 comments
Open

hashtag ligature (##) with problems in kitty terminal #141

Ordeeper opened this issue Nov 16, 2023 · 30 comments
Labels
bug Something isn't working V7 Created in V6, already fixed in V7 Beta

Comments

@Ordeeper
Copy link

Ordeeper commented Nov 16, 2023

hashtag ligature (##) with problems in kitty terminal

OS: Arch
Shell: fish
WM: i3
Terminal: tmux

Example in neovim with kitty

image

Example in kitty

image

Example in vscodium

image

NOTE: I also tried without tmux

@subframe7536
Copy link
Owner

subframe7536 commented Nov 16, 2023

does ====== ligature in Fira Code rendered correctly?

technically they are rendered in same way

@Ordeeper
Copy link
Author

Ordeeper commented Nov 17, 2023

Ye, it's rendered correctly

Fira Code

image

Maple Mono

image

@subframe7536
Copy link
Owner

have no idea how to deal with it 🥲

@Ordeeper
Copy link
Author

When I have time, I’ll take a look

@subframe7536 subframe7536 added the bug Something isn't working label Dec 8, 2023
@Cyberczy
Copy link
Contributor

Not only # has this problem, but there is also this problem in btop
image

@subframe7536 subframe7536 moved this to working in Maple Mono Dec 29, 2023
@subframe7536
Copy link
Owner

subframe7536 commented Feb 19, 2024

can you test if V7-beta2 fix this issue?

@Cyberczy
Copy link
Contributor

Cyberczy commented Feb 19, 2024

can you test if V7-beta2 fix this issue?

I cant use kitty +list-fonts --psnames | grep Maple to find MapleMono-VF, But can be found using fc-list | grep MapleMono-VF
image

@subframe7536
Copy link
Owner

subframe7536 commented Feb 19, 2024

Oh, weird things. I have little experience about kitty.

Maybe some issues with width or monospace flags

@subframe7536
Copy link
Owner

updated vf.zip, it should be correctly recognized.

can you also test if italic lll with "calt" correctly rendered?

@Cyberczy
Copy link
Contributor

I'm here to test now lol

@Cyberczy
Copy link
Contributor

Seems like there's still a bit of a size issue
image

@Cyberczy

This comment was marked as outdated.

@subframe7536
Copy link
Owner

both are not solved... cannot figure out why

@Cyberczy
Copy link
Contributor

lll have no issues image

Sorry, seems like there's still a bit of a size issue
image

@Cyberczy
Copy link
Contributor

both are not solved... cannot figure out why

Thanks for the great work here! The issue may be resolved quickly.

@subframe7536 subframe7536 added the help wanted Cannot handle this issue and need some help label Feb 21, 2024
@subframe7536
Copy link
Owner

So, if there is no enough space to render, the font size will be decreased.

It seems that it is inevitable for l related ligatures, but ### can be solved

@subframe7536 subframe7536 removed the help wanted Cannot handle this issue and need some help label Feb 23, 2024
@subframe7536
Copy link
Owner

updated MapleMono-Italic[wght]-VF.zip, support both lll and ###

@Cyberczy
Copy link
Contributor

I will test it tomorrow

@Cyberczy
Copy link
Contributor

updated MapleMono-Italic[wght]-VF.zip, support both lll and ###

It finally took effect lol
image

@Cyberczy
Copy link
Contributor

@subframe7536 Congratulations and happy Lantern Festival

@subframe7536
Copy link
Owner

Thanks, happy Lantern Festival!

However, it seems that the ### ligature is lost...

@Cyberczy
Copy link
Contributor

It seems to be, but at least we already know what the problem is, dont we?

@subframe7536
Copy link
Owner

subframe7536 commented Feb 24, 2024

However, it seems that the ### ligature is lost...

After tonight's research, based on my technical level, I believe this is due to the weird font kerning of kitty

@subframe7536 subframe7536 moved this from working to Done in Maple Mono Feb 25, 2024
@ErrorPower2001
Copy link

ErrorPower2001 commented Feb 27, 2024

I have tested the latest version of Kitty using the releases version Maple Mono SC NF, and changing the font kerning of Kitty, but the problem still persists.

# ${HOME}/.config/kitty/kitty.conf

font_family  Maple Mono SC NF

# I have tested in -4px..+4px, 80%..120%
modify_font cell_width +1px

# I have tested in -2px..+2px
modify_font cell_height +1px

And, there is a configuration of kitty font is font_feature, but I don't know how to config it for maple-font.

@subframe7536
Copy link
Owner

You should test v7-beta6. Fixes haven't be published in stable release

@subframe7536 subframe7536 added the V7 Created in V6, already fixed in V7 Beta label Mar 11, 2024
@Fr4nk1inCs
Copy link

The v6 font also has this issue.

image

@Cyberczy
Copy link
Contributor

The v6 font also has this issue.

image

Try v7-beta

@Fr4nk1inCs
Copy link

Seems v7-beta fixes the issue.

image

@Fr4nk1inCs
Copy link

Fr4nk1inCs commented May 21, 2024

And, there is a configuration of kitty font is font_feature, but I don't know how to config it for maple-font.

@ErrorPower2001 Like this:

font_features MapleMono-NF-CN-ExtraLightItalic -zero +cv01 -cv02 +cv03 -cv04 -cv99 -ss01

@K4R7IK
Copy link

K4R7IK commented Jun 9, 2024

@Fr4nk1inCs Where can I find the v7-beta?

Nevermind, found them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working V7 Created in V6, already fixed in V7 Beta
Projects
Status: Done
Development

No branches or pull requests

6 participants