Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add icon to windows executable file #26

Open
Tarek-Hasan opened this issue Apr 26, 2024 · 3 comments
Open

Add icon to windows executable file #26

Tarek-Hasan opened this issue Apr 26, 2024 · 3 comments

Comments

@Tarek-Hasan
Copy link

First, thanks for the new release. v3.1 looks better and runs smoothly compared to v2.7.

As I mentioned in the original issue of old StuntRally repo - in windows without integrated icons, stuntrally exe and shortcut files looks like corrupted or missing.

Hope, you'll fix this soon.

@cryham
Copy link
Member

cryham commented Apr 26, 2024

Yeah I know. Icons are also missing for Linux binaries and in Windows installer too. I didn't care much about those. Will add to roadmap and try doing someday.

@cryham
Copy link
Member

cryham commented Sep 23, 2024

Ok I did this with SR 3.2. It's a manual step, more to do each time.
I did a quick look and I don't think it can be added to CMake, to be automatic.
Would be way better.
A link to something similar I think:
https://forum.qt.io/topic/81519/how-to-set-the-application-icon-on-windows-using-cmake

@Tarek-Hasan
Copy link
Author

Thanks for the new release and solving the issue.

But there's a problem with uninstalling from windows settings. It searches for uninst.exe in \Stunt Rally 3.2\sr folder, but the installer puts the uninst.exe file in \Stunt Rally 3.2 which results in an error.
Screenshot 2024-09-24 143518

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants