Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Vendor extensions #123

Closed
bgardner opened this issue Oct 18, 2018 · 3 comments
Closed

Vendor extensions #123

bgardner opened this issue Oct 18, 2018 · 3 comments
Assignees

Comments

@bgardner
Copy link
Contributor

Thinking that some of the vendor extensions for transitions, border-box, and fadeins can probably be removed. @nickcernis care to take a look?

@nickcernis
Copy link
Collaborator

@bgardner Sure! I think we should automate this so we don't have to review this manually each time. I've created this PR for that purpose: #124.

It means we can type npm run autoprefixer and the stylesheet will automatically be corrected to add/remove required prefixes.

It uses the same supported browsers that WP lists to figure out which prefixes to use: https://make.wordpress.org/core/handbook/best-practices/browser-support/.

It's the same script we'll be using in Genesis, so makes sense to me to have it in child themes too.

If you're happy with this approach, I'll merge the PR and run the linter and autoprefixer on the stylesheet in a separate commit.

@bgardner
Copy link
Contributor Author

Yep, works for me. Just don't want to have unnecessary stuff in there. :-)

@nickcernis
Copy link
Collaborator

Vendor prefixes updated in fc0688b.

nickcernis added a commit that referenced this issue Oct 29, 2018
Relates to #123.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants