[BUGFIX] Fix type of v1 riddle keys

studiomitte · Feb 14, 2023 · 9d5294b · 9d5294b
1 parent 627eb75
commit 9d5294b
Show file tree

Hide file tree

Showing 3 changed files with 3 additions and 3 deletions.
diff --git a/Classes/Controller/PluginController.php b/Classes/Controller/PluginController.php
@@ -35,7 +35,7 @@ public function run(): string
         }
 
         if (MathUtility::canBeInterpretedAsInteger($riddleId)) {
-            return $this->getRiddleHtml($riddleId);
+            return $this->getRiddleHtml((int)$riddleId);
         }
         return $this->getRiddleHtmlV2($riddleId);
     }

diff --git a/Classes/Hooks/PageLayoutView.php b/Classes/Hooks/PageLayoutView.php
@@ -65,7 +65,7 @@ protected function getRiddleData($id): array
     {
         $api = GeneralUtility::makeInstance(RiddleApi::class);
         if (MathUtility::canBeInterpretedAsInteger($id)) {
-            $item = $api->getRiddleItem($id);
+            $item = $api->getRiddleItem((int)$id);
         } else {
             $item = $api->getRiddleItemV2($id);
         }

diff --git a/Classes/Utility/RiddleUtility.php b/Classes/Utility/RiddleUtility.php
@@ -53,7 +53,7 @@ public static function enrichRiddleData(array $item): array
      * Get riddle ID from given flexform XML
      *
      * @param string $flexforms
-     * @return int|string
+     * @return string
      */
     public static function getRiddleId(string $flexforms)
     {