[M4.3] Default activity completion page in Couse completion setting b… #487
+42
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The actual fix is good. The Behat changes are a problem. behat_course::i_add_to_section was added in Moodle 4.1 (MDL-79029). No need to define a custom Behat step. We can drop support for Moodle 4.0 now. It has not been supported by Moodle for ages: https://moodledev.io/general/releases. |
|
Hi @timhunt, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…roken #778312
Hi @timhunt,
I have added the suffixed name for the function add_completion_rules if the Moodle version is greater than 4.2.
Due to behat function being deprecated in 4.4, I have added a new behat function to support all versions.
I have updated the behat fail of studentquiz. Step "And I click on "New" "link" because in Moolde 4.4, we have a link "new section" which causes the behat to click the wrong link.
Could you please have a look at this change? Many thanks.