Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Signac with annotation from gtf file #1793

Open
lldelisle opened this issue Sep 30, 2024 · 2 comments
Open

Use Signac with annotation from gtf file #1793

lldelisle opened this issue Sep 30, 2024 · 2 comments
Labels
documentation Documentation help

Comments

@lldelisle
Copy link

Dear Signac developpers,
I realized that signac requires that the Annotation slot gets the transcript ids stored into tx_id. While it is the case for the annotations from GetGRangesFromEnsDb, it is not the case from the import from file.
I don't know if the best place is in the code of signac or in the vignettes and/or in the man for CreateChromatinAssay but would be good to introduce a:

if (is.null(annotation$tx_id)) {
  annotation$tx_id <- annotation$transcript_id
}

I would be happy to write a PR if you tell me where you prefer.

@lldelisle lldelisle added the documentation Documentation help label Sep 30, 2024
@lldelisle lldelisle changed the title Use Signac with gtf from file Use Signac with annotation from gtf file Sep 30, 2024
@timoast
Copy link
Collaborator

timoast commented Oct 7, 2024

If you'd like to take a shot at adding this to the gene annotation setter function I'd be happy to incorporate something like this into Signac

} else if (layer == "annotation") {

@lldelisle
Copy link
Author

See #1797

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Documentation help
Projects
None yet
Development

No branches or pull requests

2 participants