From 6a55ae54226e5b166f2f8bb61a13a2e0489c139e Mon Sep 17 00:00:00 2001 From: Stuart Bradley Date: Wed, 21 Feb 2024 09:23:14 +0000 Subject: [PATCH] Added Github issue links --- documentation/functional_requirements_specification.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/documentation/functional_requirements_specification.md b/documentation/functional_requirements_specification.md index 3eb5140..92fc53d 100644 --- a/documentation/functional_requirements_specification.md +++ b/documentation/functional_requirements_specification.md @@ -248,11 +248,11 @@ Taken from this [document](https://idoc.pub/documents/catan-components-list-wl1p 1. The [Cypress Github Action](https://github.com/cypress-io/github-action) caused a failure on the `should change select values when use-seafarers is checked` test, as it could not find the new options in the select. The test works locally, and fine when a manual github action is setup. -2. `TypeError: useFormStatus is not a function` when Component testing ``. This appears to be a Typescript +2. [#6](https://github.com/stuart-bradley/catan-randomiser-js/issues/6): `TypeError: useFormStatus is not a function` when Component testing ``. This appears to be a Typescript issue, but the functionality is not required for MVP so has been removed. 3. Different sizes of board change the SVG viewport, moving and scaling the SVG differently. Functionality should be added to change teh `` component `size` and `origin` props based on the incoming board. -4. The Next.js [App Router](https://nextjs.org/docs/app) does not have functionality for +4. [#7](https://github.com/stuart-bradley/catan-randomiser-js/issues/7) The Next.js [App Router](https://nextjs.org/docs/app) does not have functionality for [shallow routing](https://nextjs.org/docs/pages/building-your-application/routing/linking-and-navigating#shallow-routing) (which the Page Router does). This means it's not possible to avoid a redirect to update the URL and form state is lost. Again, this is not MVP functionality so can be ignored for now.