Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support adding files from different directories? #13

Open
QiangF opened this issue Sep 23, 2019 · 4 comments
Open

Support adding files from different directories? #13

QiangF opened this issue Sep 23, 2019 · 4 comments
Labels
enhancement New feature or request

Comments

@QiangF
Copy link

QiangF commented Sep 23, 2019

Dired rsync is amazing, it will be better if it can :

  1. selected files in multiple dired buffers is added to a list
  2. in dired-rsync--filter, the file that complete successfully is removed and unmarked in the source dir

Point 1 is because many user often need to copy files from multiple dirs to one target dir.

Point 2 is because the rsync process might be interrupted, it will be easier for the user to act further upon the failed files if they are left marked, if there are many dired buffers it 's better to differentiate form "*" by setting the dired-marker-char to "F",meaning failed. (the user can change marks with dired-change-marks)

@stsquad
Copy link
Owner

stsquad commented Nov 8, 2019

Would it be all dired marks or all dired marks bellow the invoked directory. In principle you could write a fetcher to collect all the paths.

stsquad added a commit that referenced this issue Nov 8, 2019
Provide a hook (dired-rsync-source-files) so users can replace the
default with their own approach to gathering marked files from the
dired-buffer.
@stsquad
Copy link
Owner

stsquad commented Nov 8, 2019

For point 2 we already have a hook into the sentinel for detecting the passphrase appearing. Maybe we should have a cleaner hook for this?

@QiangF
Copy link
Author

QiangF commented Nov 9, 2019

If you can let the user see the list of failed files surely helps.

@stsquad
Copy link
Owner

stsquad commented Feb 14, 2020

It's hard to gauge that from the rsync output. If there is an invocation that gives a clean list of failed files we could scrape that information from the process buffer.

@stsquad stsquad added the enhancement New feature or request label Feb 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants