Skip to content
This repository has been archived by the owner on Mar 25, 2021. It is now read-only.

Implement model & controller for Topics (listing) page #124

Closed
pmuir opened this issue Nov 19, 2020 · 2 comments · May be fixed by #136
Closed

Implement model & controller for Topics (listing) page #124

pmuir opened this issue Nov 19, 2020 · 2 comments · May be fixed by #136
Assignees
@ajborley
Labels
Stale

Comments

@pmuir
Copy link
Contributor

pmuir commented Nov 19, 2020 •
edited
Loading

Implement the model & controller for the Topics (listing) page. #70 contains the designs. See also #123 and #122 for the view implementations.
@matthew-chirgwin
Copy link
Member

For the first stage, I am hoping this will be a simple model hook, calling a useQuery to get the data/deal with loading/errors etc.

I expect while this will be quite boilerplate like for now, other functions etc will follow/be added to this model

@ajborley ajborley self-assigned this Nov 30, 2020
ajborley added a commit to ajborley/strimzi-ui that referenced this issue Dec 2, 2020
@ajborley
feat: Add useTopics model hook and query for topics listing
bc9ca89 
 - This commit adds a new `useTopics` model hook, which makes GraphQL
requests to the server to administer Kafka topics.
 - The hook returns a set of sub-hooks, with just the `useGetTopics`
sub-hook implemented for now which returns the list of topics (including
their name, number of partitions and number of replicas).

Contributes to: strimzi#124

Signed-off-by: Andrew Borley <[email protected]>
ajborley added a commit to ajborley/strimzi-ui that referenced this issue Dec 2, 2020
@ajborley
feat: Add useTopics model hook and query for topics listing
7738866 
 - This commit adds a new `useTopics` model hook, which makes GraphQL
requests to the server to administer Kafka topics.
 - The hook returns a set of sub-hooks, with just the `useGetTopics`
sub-hook implemented for now. `useGetTopics` returns the list of topics
(including name, number of partitions and number of replicas).

Contributes to: strimzi#124

Signed-off-by: Andrew Borley <[email protected]>
ajborley added a commit to ajborley/strimzi-ui that referenced this issue Dec 2, 2020
@ajborley
feat: Add useTopics model hook and query for topics listing
70105af 
 - This commit adds a new `useTopics` model hook, which makes GraphQL
requests to the server to administer Kafka topics.
 - The hook returns a set of sub-hooks, with just the `useGetTopics`
sub-hook implemented for now. `useGetTopics` returns the list of topics
(including name, number of partitions and number of replicas).

Contributes to: strimzi#124

Signed-off-by: Andrew Borley <[email protected]>
@ajborley ajborley mentioned this issue Dec 2, 2020
Open
@matthew-chirgwin matthew-chirgwin linked a pull request Dec 3, 2020 that will close this issue
feat: Add useTopics model hook and query for topics listing #136
Open
ajborley added a commit to ajborley/strimzi-ui that referenced this issue Dec 4, 2020
@ajborley
feat: Add useTopics model hook and query for topics listing
b7111e6 
 - This commit adds a new `useTopics` model hook, which makes GraphQL
requests to the server to administer Kafka topics.
 - The hook returns a set of sub-hooks, with just the `useGetTopics`
sub-hook implemented for now. `useGetTopics` returns the list of topics
(including name, number of partitions and number of replicas).

Contributes to: strimzi#124

Signed-off-by: Andrew Borley <[email protected]>
ajborley added a commit to ajborley/strimzi-ui that referenced this issue Dec 4, 2020
@ajborley
fix: Refactor to Topic panel
1da8fda 
 - Addresses initial review comments.

Contributes to: strimzi#124

Signed-off-by: Andrew Borley <[email protected]>
ajborley added a commit to ajborley/strimzi-ui that referenced this issue Dec 7, 2020
@ajborley
fix: Initial Model update
86cd532 
 - Based on review comments from @matthew-chirgwin

Contributes to: strimzi#124

Signed-off-by: Andrew Borley <[email protected]>
pmuir pushed a commit to pmuir/strimzi-ui that referenced this issue Dec 9, 2020
@ajborley @pmuir
feat: Add useTopics model hook and query for topics listing
889de0f 
 - This commit adds a new `useTopics` model hook, which makes GraphQL
requests to the server to administer Kafka topics.
 - The hook returns a set of sub-hooks, with just the `useGetTopics`
sub-hook implemented for now. `useGetTopics` returns the list of topics
(including name, number of partitions and number of replicas).

Contributes to: strimzi#124

Signed-off-by: Andrew Borley <[email protected]>
pmuir pushed a commit to pmuir/strimzi-ui that referenced this issue Dec 9, 2020
@ajborley @pmuir
fix: Refactor to Topic panel
0c58f49 
 - Addresses initial review comments.

Contributes to: strimzi#124

Signed-off-by: Andrew Borley <[email protected]>
pmuir pushed a commit to pmuir/strimzi-ui that referenced this issue Dec 9, 2020
@ajborley @pmuir
fix: Initial Model update
29488c4 
 - Based on review comments from @matthew-chirgwin

Contributes to: strimzi#124

Signed-off-by: Andrew Borley <[email protected]>
@github-actions
Copy link

This issue is stale because it has been open 30 days with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the Stale label Dec 31, 2020
@github-actions github-actions bot closed this as completed Jan 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@ajborley ajborley

Labels
Stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: Add useTopics model hook and query for topics listing ajborley/strimzi-ui
3 participants
@pmuir @ajborley @matthew-chirgwin