Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for mounting CSI volumes #138

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

scholzj
Copy link
Member

@scholzj scholzj commented Nov 23, 2024

This proposal adds support for mounting CSI volumes in the additional volumes template. This can be used to mount various secrets using special CSI drivers. Implementation of this proposal should help to address strimzi/strimzi-kafka-operator#5277.

Copy link
Contributor

@PaulRMellor PaulRMellor left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The proposal seems relatively straightforward for a very useful addition, helped by the recent support for additional volumes. I left a few minor comments from review.

088-support-mounting-of-CSI-volumes.md Outdated Show resolved Hide resolved
088-support-mounting-of-CSI-volumes.md Outdated Show resolved Hide resolved
088-support-mounting-of-CSI-volumes.md Outdated Show resolved Hide resolved
088-support-mounting-of-CSI-volumes.md Outdated Show resolved Hide resolved
088-support-mounting-of-CSI-volumes.md Outdated Show resolved Hide resolved
088-support-mounting-of-CSI-volumes.md Outdated Show resolved Hide resolved
088-support-mounting-of-CSI-volumes.md Outdated Show resolved Hide resolved
088-support-mounting-of-CSI-volumes.md Outdated Show resolved Hide resolved
088-support-mounting-of-CSI-volumes.md Outdated Show resolved Hide resolved
088-support-mounting-of-CSI-volumes.md Show resolved Hide resolved
scholzj and others added 2 commits November 25, 2024 15:06
Co-authored-by: PaulRMellor <[email protected]>
Signed-off-by: Jakub Scholz <[email protected]>
Signed-off-by: Jakub Scholz <[email protected]>
Copy link
Member

@see-quick see-quick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@ppatierno ppatierno left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@scholzj
Copy link
Member Author

scholzj commented Nov 28, 2024

This proposal now has 4 +1 votes. If there are no new comments tomorrow EOB, I will close the vote. Thanks.

Copy link
Member

@tombentley tombentley left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @scholzj

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants