-
Notifications
You must be signed in to change notification settings - Fork 58
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for mounting CSI volumes #138
base: main
Are you sure you want to change the base?
Conversation
Signed-off-by: Jakub Scholz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The proposal seems relatively straightforward for a very useful addition, helped by the recent support for additional volumes. I left a few minor comments from review.
Co-authored-by: PaulRMellor <[email protected]> Signed-off-by: Jakub Scholz <[email protected]>
Signed-off-by: Jakub Scholz <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This proposal now has 4 +1 votes. If there are no new comments tomorrow EOB, I will close the vote. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @scholzj
This proposal adds support for mounting CSI volumes in the additional volumes template. This can be used to mount various secrets using special CSI drivers. Implementation of this proposal should help to address strimzi/strimzi-kafka-operator#5277.