Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CSpell is not respecting the words from the global VSCode settings file #3846

Open
GYuriy opened this issue Nov 25, 2024 · 8 comments
Open

Comments

@GYuriy
Copy link

GYuriy commented Nov 25, 2024

I have all my words that should be considered correct in my global VSCode settings file (AppData\Roaming...):

"cSpell.userWords": [
...
]

After the recent update, none of these words are no longer taken into account by the extension.

@Jason3S
Copy link
Collaborator

Jason3S commented Nov 26, 2024

Please make sure cSpell.userWords isn't in a .vscode/settings.json file. VS Code will override the global setting.

The user setting:
image

Will show Also modified in Workspace.
image

If you see Also modified in Workspace, then the value is getting overwritten.

@djedu28
Copy link

djedu28 commented Nov 27, 2024

The best expected behavior is to unite/concatenate information from different sources.
Using both information from:

  1. file.code-workspace -> cSpell.* (being local configuration);
  2. .vscode/settings.json (being local configuration);
  3. and user profile cSpell.* (being global configuration).

Having local information (file.code-workspace) with priority in case of conflicts.

edit.: I listed the priority order of the settings in case of conflicts

original text (pt-BR)

O melhor comportamento esperado é unir/concatenar as informações das diversas origens.
Usando tanto as informações de:

  1. file.code-workspace -> cSpell.* (sendo configuração local);
  2. .vscode/settings.json (sendo configuração local);
  3. e do perfil do usuário cSpell.* (sendo configuração global).

Tendo as informações locais (file.code-workspace) com prioridade em caso de conflitos.

edit.: Enumerei a ordem de prioridade das configurações em caso de conflitos

@GYuriy
Copy link
Author

GYuriy commented Nov 27, 2024

I tried to reinstall the recent version again, and I've noticed two issues:

  1. After the extension host is restarted, I get an error No view is registered with id: cSpellIssuesViewByFile
  2. I have enabled CSpell logs I found this:
2024-11-27 15:34:51.041 [error] Failed to find document for vscode-userdata:/c%3A/Users/y**********h/AppData/Roaming/Code/User/settings.json

The error above probably explains why my custom words are not working, but the extension has no issue locating the config file 3.0.1 (I'm currently using 3.0.1 right now)

p.s. Not sure what c%3A in the file path is...

@Jason3S
Copy link
Collaborator

Jason3S commented Nov 27, 2024

@GYuriy,

I tried to reinstall the recent version again, and I've noticed two issues:

  1. After the extension host is restarted, I get an error No view is registered with id: cSpellIssuesViewByFile
  • No view is registered with id: cSpellIssuesViewByFile is a known bug in VS Code. And doesn't impact the operation of the spell checker.
  1. I have enabled CSpell logs I found this:
2024-11-27 15:34:51.041 [error] Failed to find document for vscode-userdata:/c%3A/Users/y**********h/AppData/Roaming/Code/User/settings.json

The error above probably explains why my custom words are not working, but the extension has no issue locating the config file 3.0.1 (I'm currently using 3.0.1 right now)

p.s. Not sure what c%3A in the file path is...

This shouldn't be an issue. It shows up when trying to edit the global settings. The spell checker asks VS Code for the settings. I'll address this issue, but it is unrelated to what you are seeing.

c%3A is c:.

Something else is blocking the setting from getting through.

@Jason3S
Copy link
Collaborator

Jason3S commented Nov 27, 2024

@djedu28,

The best expected behavior is to unite/concatenate information from different sources. Using both information from:

  1. file.code-workspace -> cSpell.* (being local configuration);
  2. .vscode/settings.json (being local configuration);
  3. and user profile cSpell.* (being global configuration).

Having local information (file.code-workspace) with priority in case of conflicts.

edit.: I listed the priority order of the settings in case of conflicts

Extensions have no control over the order in which the settings are merged. See VS Code Settings Precedence

@djedu28
Copy link

djedu28 commented Nov 28, 2024

@Jason3S

Extensions have no control over the order in which the settings are merged. See VS Code Settings Precedence

I thank you for the information

@GYuriy
Copy link
Author

GYuriy commented Dec 5, 2024

@Jason3S I'm still trying to figure out what else could change between 3.0.1 and 4+ and caused the issue

@Jason3S
Copy link
Collaborator

Jason3S commented Dec 18, 2024

@GYuriy,

I'm not sure if it has fixed the issue, but please try the pre-release version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants