Add remove property functions #856
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lovrogalesic-toast
requested review from
nodece,
zymap and
a team
as code owners
nodece
reviewed
Oct 17, 2022
Co-authored-by: Zixuan Liu <[email protected]>
|
@lovrogalesic-toast Could you check the failed CI? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #855
Motivation
This PR adds the ability to unset some namespace properties instead of always setting them to the value of
0.The goal is to unset the properties when they are removed from the terraform declarations when using
terraform-provider-pulsarModifications
-1for unset,0is zero...)Verifying this change
Tests to add:
Documentation
Check the box below.
Need to update docs?
doc-requiredThese changes should be documented and explained as they might be breaking for some users.