Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

argocd app delete is stuck with 'CleanUpAfterDeletion' enabled #160

Open
mingmcb opened this issue Sep 28, 2023 · 4 comments
Open

argocd app delete is stuck with 'CleanUpAfterDeletion' enabled #160

mingmcb opened this issue Sep 28, 2023 · 4 comments

Comments

@mingmcb
Copy link
Contributor

mingmcb commented Sep 28, 2023

when use argocd deploy the helm chart, we're not be able to delete the app when 'CleanUpAfterDeletion' enabled.

the work around is to set the the argocd finalizers to use resources-finalizer.argocd.argoproj.io/background.

Please take a look.

@ericsyh
Copy link
Member

ericsyh commented Oct 7, 2023

@mingmcb Can you share the manifests from the helm chart?

@ericsyh
Copy link
Member

ericsyh commented Oct 7, 2023

I guess this is caused by #69
For now, resource operator is using an all-in-one controller, and also the topic, namespace currently has no dependency management #130 which usually cause resource blocked during the deleting phase.

@ericsyh ericsyh added this to the 0.5.0 milestone Oct 7, 2023
@mingmcb
Copy link
Contributor Author

mingmcb commented Oct 9, 2023

yes, it is possible. You can test it out by creating a helm charts with CleanUpAfterDeletion enabled. A sample argocd app as shown below can be used for testing, the app will be in stuck if you try to delete.
apiVersion: "argoproj.io/v1alpha1" kind: "Application" metadata: finalizers: - "resources-finalizer.argocd.argoproj.io" name: "pulsar-resources-test" spec: project: applications source: repoURL: 'https://chartrepo' targetRevision: x.x.x chart: test-chart destination: namespace: ns-1 name: cluster-1

@tomjo
Copy link
Contributor

tomjo commented Jan 24, 2024

In our case we are working around this issue by using argocd sync-waves to ensure deletion in a specific order

@ericsyh ericsyh removed this from the 0.5.0 milestone Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants