Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve integration tests for SponsorshipCreated #157

Open
orestes opened this issue May 1, 2020 · 0 comments
Open

Improve integration tests for SponsorshipCreated #157

orestes opened this issue May 1, 2020 · 0 comments
Labels
enhancement General enhancement

Comments

@orestes
Copy link
Collaborator

orestes commented May 1, 2020

We only have one test, which is not really checking the content of the response.

https://github.com/streamdevs/webhook/blob/master/test/routes/github/sponsorship.spec.ts#L31

We could improve this a bit by maybe checking the HTTP status code instead.

@orestes orestes added the enhancement General enhancement label May 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement General enhancement
Projects
None yet
Development

No branches or pull requests

1 participant