Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deleted half my files (Even local backups) #27

Open
Excadite opened this issue May 27, 2024 · 5 comments
Open

Deleted half my files (Even local backups) #27

Excadite opened this issue May 27, 2024 · 5 comments

Comments

@Excadite
Copy link

When downloading files it errors and deleted half of the files.

I dont have the logs because it deleted them too

DO NOT USE THIS PLUGIN ITS UNSTABLE

@stravo1
Copy link
Owner

stravo1 commented May 27, 2024

the plug-in is in it's beta stage and thus is bound to have bugs, it is clearly mentioned in the README.

Screenshot_20240527-191657~2.png

sorry for the inconvenience, did it delete files from the device from which the vault was initialised? it should not try to download files on the device which contains the original files, it will only download files on a device which is missing those files, i don't understand how it can delete files while "downloading"...

can you test it on a new vault and report back the results?

@stravo1
Copy link
Owner

stravo1 commented May 27, 2024

also can you please describe what you mean by "local backups"? the plug-in (in fact any plug-in) has access to only the files in the vault, if you created a back-up of the vault in some other location, it cannot access those backups.

did you mean the local files on your vault?

@jack5github
Copy link

I experienced the exact same problem as the original poster. Fortunately I am a new user of Obsidian, so this wasn't as big of an issue as it may have been. As I am a new user, I have been attempting to create and import files from various sources. I found myself annoyed by this plugin because it was arbitrarily deciding what to sync, was never privy to when I renamed files, and failed to start syncing files when I clicked the Upload File and Upload All Files buttons. Frustrated with the plugin, I deleted all files from the Google Drive backup and cleared the "filesList" key in data.json. To my horror, all of the notes that I had created were deleted the next time I opened the application, with absolutely no way of getting them back. Deleting files like this without confirmation is an absolutely terrible way to handle syncing in beta. Please fix the project so that it simply moves files to a obsidian-gdrive-sync-deleted folder instead of removing the files themselves.

@stravo1
Copy link
Owner

stravo1 commented Jun 9, 2024

hi,

thank you for providing an alternative solution to the deletion issue that exists, i think this will greatly help in recovering mistakenly deleted files.

however deleting files from Google Drive without deleting the vault folder signals to the plug-in that some other device might have deleted them from the Drive, this is because the files which were once synced (had the lastSync tag), are no more there in the Drive, which tells the plug-in that another device has deleted those files and thus in order to keep the vault in sync the files were deleted from your local vault as well.

the Upload All button will be removed in future updates because it's no longer required as notes will auto upload even if they were somehow not uploaded initially.

renaming files in vault renames them on Drive but at times it might happen that the original file (file before renaming) is downloaded again and then deleted or the renamed file gets deleted and then downloaded again, this happens in some race conditions. These situations should not arise frequently but even in such cases no data should be lost.

@stravo1
Copy link
Owner

stravo1 commented Jun 9, 2024

files are now moved to ".trash" folder under the vault instead of being deleted permanently at https://github.com/stravo1/obsidian-gdrive-sync/releases/tag/v0.9.9-beta-11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants