Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

change package.json "type" for module Resolving issue #49 #50

Merged
merged 1 commit into from
Nov 4, 2024

Conversation

Rmoreno3
Copy link
Contributor

What does it do?

Change in the package.json 'type' commonjs for module

Why is it needed?

Resolve issue #49 for correction the bug

How to test it?

install the package @strapi/blocks-react-render and run the project whit nextjs, import the compoenet BlocksRenderer and using

Related issue(s)/PR(s)

Resolving issue #49

@simotae14 simotae14 self-requested a review October 31, 2024 11:01
Copy link
Contributor

@simotae14 simotae14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the contribution @Rmoreno3 well done 👏🏽

Approved 👍🏽

@Rmoreno3
Copy link
Contributor Author

Rmoreno3 commented Nov 2, 2024

Thanks a lot 🫱🏽‍🫲🏽

@Rmoreno3 Rmoreno3 closed this Nov 2, 2024
@Rmoreno3 Rmoreno3 reopened this Nov 2, 2024
@Rmoreno3
Copy link
Contributor Author

Rmoreno3 commented Nov 2, 2024

Can you approve the pr to merge with main? @simotae14

Copy link
Contributor

@simotae14 simotae14 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

well done 👏🏽

@simotae14 simotae14 merged commit 032e256 into strapi:main Nov 4, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants