Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

go.mod has replace directories causing "go install" to show warning #84

Open
boojamya opened this issue Jan 27, 2022 · 3 comments
Open
Labels
Type: Question Clarification needed

Comments

@boojamya
Copy link
Contributor

If a user wants to use Lens inside of another go project, they will need to use go install github.com/strangelove-ventures/lens@latest

This command produces the following error:

        The go.mod file for the module providing named packages contains one or
        more replace directives. It must not contain directives that would cause
        it to be interpreted differently than if it were the main module.

Is it necessary to use these replaces?

lens/go.mod

Lines 115 to 117 in 69827ed

replace google.golang.org/grpc => google.golang.org/grpc v1.33.2
replace github.com/gogo/protobuf => github.com/regen-network/protobuf v1.3.3-alpha.regen.1

@boojamya boojamya added the Type: Question Clarification needed label Jan 27, 2022
@boojamya boojamya changed the title go.mod has replace directories causing "go install" to fail go.mod has replace directories causing "go install" to show warning Jan 27, 2022
@tac0turtle
Copy link
Contributor

we can remove the grpc replace tag with 0.46 of the sdk. Also I don't think this repo needs the second replace tag, right @fdymylja

@fdymylja
Copy link

fdymylja commented Feb 6, 2022

we can remove the grpc replace tag with 0.46 of the sdk. Also I don't think this repo needs the second replace tag, right @fdymylja

correct. just make sure to upgrade to latest sdk version, otherwise if you use proto or grpc you might incur in panics without the replace directive.

@boojamya
Copy link
Contributor Author

boojamya commented Feb 7, 2022

Good to know!
Appreciate the feedback here. @marbar3778 @fdymylja

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Question Clarification needed
Projects
None yet
Development

No branches or pull requests

3 participants