Skip to content
This repository has been archived by the owner on Feb 23, 2024. It is now read-only.

lens tx staking delegate not working #104

Open
boojamya opened this issue Feb 19, 2022 · 4 comments
Open

lens tx staking delegate not working #104

boojamya opened this issue Feb 19, 2022 · 4 comments
Labels
Type: Bug 🪲 Inconsistencies or issues which will cause an issue or problem for users or implementors.

Comments

@boojamya
Copy link
Contributor

In cmd > staking.go

I believe lines 34-36 needs to be removed:

			if args[2] != cl.Config.Key {
				cl.Config.Key = args[2]
			}

Also, the transaction flags flags.AddTxFlagsToCmd(cmd) (Line 75) are not working properly.

@boojamya boojamya added the Type: Bug 🪲 Inconsistencies or issues which will cause an issue or problem for users or implementors. label Feb 19, 2022
@tac0turtle
Copy link
Contributor

can we move away from so many args and use flags, this will fix most of these issues

right now we do weird argsrange(0,2) and it causes the code to be quite ugly and unmaintainable.

@andynog
Copy link
Contributor

andynog commented Feb 25, 2022

@boojamya If you are OK with that, I can fix this one, I've been working on this indirectly in #103 for the bank module and trying to make the code more standardized across all the commands and adding flags to them to make it more close to the sdk cli's

@boojamya
Copy link
Contributor Author

Be my guest, thanks @andynog !

Side note, I did in-fact get this working by removing those lines noted in my comment above. And also txflags, are not hooked up to anything, specifically the --dry-run flag, so lets just say I have a small amount of funds that are locked up staking for a bit 🙃
#mainnet

@andynog
Copy link
Contributor

andynog commented Feb 25, 2022

hooked-up the flags (pagination and height) to the bank queries here -> 21dd33c

@andynog andynog self-assigned this Feb 25, 2022
@andynog andynog removed their assignment May 9, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Type: Bug 🪲 Inconsistencies or issues which will cause an issue or problem for users or implementors.
Projects
None yet
Development

No branches or pull requests

3 participants