This repository has been archived by the owner on Feb 9, 2024. It is now read-only.
Make floating tools compatible with inline (contenteditable) editors #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use offsetX/Y for mouse position (instead of clientX/Y) to keep it relative to inline editor, use `editor.element` to get editor instance and establish initial offsets instead of `editor.ui.spaceId`.
|
Did some more testing. These changes aren’t enough to fix this plugin for contenteditable-based inline CKEditor instances. Including this plugin messes up with editor selection and basic usage of the editor (caret jumps around, selections sometimes deselect). |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Includes changes for mouse position and editor offset calculations (use offsetX/Y for mouse position (instead of clientX/Y) to keep it relative to inline editor, use
editor.elementto get editor instance and establish initial offsets instead ofeditor.ui.spaceId). I didn’t test it with the classic iframe-based editor instances, and it still isn’t perfect, but it gets the plugin closer and prevents JS errors.Intended to fix #5