Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

skipRemoteConfig Necessary? #45

Open
rdegges opened this issue Mar 22, 2016 · 2 comments
Open

skipRemoteConfig Necessary? #45

rdegges opened this issue Mar 22, 2016 · 2 comments

Comments

@rdegges
Copy link

rdegges commented Mar 22, 2016

if (config.skipRemoteConfig) {
return callback(null, config);
}

It looks like this was just added for testing convenience. Are we using this anywhere else? I'm working on the python version of this, and can't really seem to find a use for it.

Thinking about dropping support for it, but didn't want to break anything =)

@robertjd
Copy link
Member

I'm pretty sure that we removed anything that depended on it, that was our intention. I'd need to dig in to be certain, though.

@typerandom
Copy link
Contributor

Yeah, this was really just a convenience thing for testing. It should probably be refactored :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants