Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BCrypt code quality #1

Open
edjiang opened this issue Aug 4, 2016 · 2 comments
Open

BCrypt code quality #1

edjiang opened this issue Aug 4, 2016 · 2 comments

Comments

@edjiang
Copy link
Contributor

edjiang commented Aug 4, 2016

I'm not happy with the code quality of the BCrypt implementation I imported. This is one of the few BCrypt implementations in Swift (thanks @Joannis for porting @meanjoe45's Swift 1 implementation), so will have to do for now.

BCrypt is passing tests for now, so I'll clean up the API and punt on the decision to audit / improve the code quality myself, or wait for a more popular BCrypt library to pop up on Swift.

@edjiang
Copy link
Contributor Author

edjiang commented Aug 16, 2016

Fixed up a lot of this in fb545e6 so the public API can be more stable, although the internals are still a bit messy. @Joannis might wanna check out the changes =]

@Joannis
Copy link

Joannis commented Aug 16, 2016

Will do!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants