Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Linksharing: Open Graph meta tags #431

Open
mobyvb opened this issue Apr 23, 2024 · 1 comment
Open

Linksharing: Open Graph meta tags #431

mobyvb opened this issue Apr 23, 2024 · 1 comment
Labels
console team console team related work

Comments

@mobyvb
Copy link
Member

mobyvb commented Apr 23, 2024

Currently, when a linksharing link is shared on social media, there is no preview image, or other information that would make the shared link more eye-catching.

This should be easy to solve by adding Open Graph meta tags.

AC:

  • Add og:title meta tag to file share <head> code with content set to the filename
  • If an image preview is possible, add og:image meta tag to file share <head> code with content set to the path of the preview. For an image, this would be the same page, but with the query param ?download=1 set
@mobyvb mobyvb added Needs Estimation console team console team related work labels Apr 23, 2024
@Zetanova
Copy link

It got already implemented see

But there is a bug when using it on custom domains.
If a custom domain is used then they still generate link.storjshare.io url’s to a 404 response.

Example:
https://mydomain.test/2024-29/T11187a.png?wrap

will include for the og:image and twitter:image html meta tags the url:
https://link.storjshare.io/raw/my-bucket/2024-29/T11187a.png?v=ab52919
and it returns 404

I reported it also in the forum here

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
console team console team related work
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mobyvb @Zetanova @NiaStorj