Improvement Suggestions

[daallgeier]

We really should add the Contributors.md from the parent repository and maybe a link to something like this to make it easier for submitters.

Originally posted by @mbainter in #43 (comment)

[daallgeier]

@mbainter I added this, actually. So would be great to have some improvements here too.

[daallgeier]

There has also been a pull request done a couple of days ago to the original one which splits the vendors into a file each. This looks more maintainable. https://github.com/robchahin/sso-wall-of-shame/tree/master/_vendors

[mbainter]

I noticed it became active again. I really wish there weren't two projects, but given that Rob still seems not to want to open it up I don't think it can be avoided.

I'm not sure how much difference it makes to split it into multiple files for something like this, but I'm not opposed.

[daallgeier]

I think keeping to the same structure helps when trying to push a pull request back to rob. Same with if we pull from there. Having a file each will also help with creating new pull requests (from Issues) as one doesn't have to go into the file, look for the right position, add the content, and then create the pull request.

…

On Tue, 12 Apr 2022 at 23:55, Mark Bainter ***@***.***> wrote: I noticed it became active again. I really wish there weren't two projects, but given that Rob still seems not to want to open it up I don't think it can be avoided. I'm not sure how much difference it makes to split it into multiple files for something like this, but I'm not opposed. — Reply to this email directly, view it on GitHub <#46 (reply in thread)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/ACJRAFL67O54ZDT5VVUUE4TVEXWNTANCNFSM5TILUNWA> . You are receiving this because you authored the thread.Message ID: <stopthessotax/sso-wall-of-shame/repo-discussions/46/comments/2555350@ github.com>

[grbray]

I would love to have them separated so I can do a PR here and not impact the rest of the list. Helps avoid merge conflicts too.