Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Failing Test: bundle with no custom roots should track usage of $refs #49

Open
brendarearden opened this issue Sep 28, 2023 · 0 comments
Labels
bug Something isn't working

Comments

@brendarearden
Copy link

brendarearden commented Sep 28, 2023

Context

The test bundle with no custom roots should track usage of $refs has been failing for sometime in the pipeline.

Current Behavior

Test is failing due to the objects not matching:

Actual:

{
    "#/properties/bar": "http://localhost:9876/context.html#/properties/foo",
    "#/properties/baz": "http://localhost:9876/context.html#/properties/foo/properties/id"
}

Expected:

{
    "#/properties/bar": "http://localhost:9876/base/test//#/properties/foo",
    "#/properties/baz": "http://localhost:9876/base/test//#/properties/foo/properties/id"
}

Seems like this is whats causing the issue - in a browser this returns the browser url, e.g. http://localhost:9876/context.html, not the source file directory :

args.path = url.resolve(url.cwd(), args.path);

Expected Behavior

The actual should match the expected.

Possible Workaround/Solution

Test has been skipped: 446ca7a

Steps to Reproduce

I recommend changing the karma.conf.js to include only one browser to save time / headaches when testing locally.

  browsers: {
    chrome: host.ci ? host.os.linux : true,
    firefox: false,
    safari: false,
  },

Remove skip from test
Run tests locally

@brendarearden brendarearden added the bug Something isn't working label Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant