Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JSON Schema Generator using deprecated request library #191

Open
strmer15 opened this issue May 17, 2022 · 0 comments
Open

JSON Schema Generator using deprecated request library #191

strmer15 opened this issue May 17, 2022 · 0 comments

Comments

@strmer15
Copy link
Contributor

The @stoplight/json-schema-generator package is using the deprecated request library, which results in these yarn warnings when installing:

warning @stoplight/prism-cli > @stoplight/http-spec > @stoplight/json-schema-generator > [email protected]: request has been deprecated, see https://github.com/request/request/issues/3142
warning @stoplight/prism-cli > @stoplight/http-spec > @stoplight/json-schema-generator > request > [email protected]: Please upgrade  to version 7 or higher.  Older versions may use Math.random() in certain circumstances, which is known to be problematic.  See https://v8.dev/blog/math-random for details.
warning @stoplight/prism-cli > @stoplight/http-spec > @stoplight/json-schema-generator > request > [email protected]: this library is no longer supported

I've created stoplightio/json-schema-generator#7 to fix this, but can't find anyone willing to review it and merge. Looks like others noticed this in #92 but it was closed without fixing the problem.

Context

Fix yarn and npm warnings about using a deprecated library.

Current Behavior

Installing @stoplight/http-spec or @stoplight/prism-cli causes yarn to emit warnings about using a deprecated library.

Expected Behavior

No warnings should be in the output.

Possible Solution(s)

Merge the change in stoplightio/json-schema-generator#7 to use node-fetch instead.

@therve therve mentioned this issue Mar 21, 2023
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant