https://issues.redhat.com/browse/ACM-13324 #7246
Conversation
| [#prevent-backup-collision] | ||
| == Preventing backup collisions | ||
|
|
||
| To prevent and report backup collisions, a `BackupCollision` state exists for the `BackupSchedule.cluster.open-cluster-management.io` resource. The controller checks regularly if the latest backup in the storage location has been generated from the current hub cluster. If not, a different hub cluster has recently written backup data to the storage location, indicating that the hub cluster is colliding with a different hub cluster. |
There was a problem hiding this comment.
To prevent and report backup collisions, a BackupCollision state exists for the BackupSchedule.cluster.open-cluster-management.io resource.
This line is confusing, I think the word exists here and To prevent.....
I think rearrage this just to say X does Y??
|
|
||
| To prevent and report backup collisions, a `BackupCollision` state exists for the `BackupSchedule.cluster.open-cluster-management.io` resource. The controller checks regularly if the latest backup in the storage location has been generated from the current hub cluster. If not, a different hub cluster has recently written backup data to the storage location, indicating that the hub cluster is colliding with a different hub cluster. | ||
|
|
||
| In this case, the current hub cluster `BackupSchedule.cluster.open-cluster-management.io` resource status is set to `BackupCollision` and the `Schedule.velero.io` resources created by this resource are deleted to prevent data corruption. The `BackupCollision` is reported by the backup policy. The administrator verifies which hub cluster writes to the storage location, before removing the `BackupSchedule.cluster.open-cluster-management.io` resource from the invalid hub cluster and creating a new `BackupSchedule.cluster.open-cluster-management.io` resource on the valid primary hub cluster, to resume the backup. |
There was a problem hiding this comment.
In all of the tech writing, please look at words like "in this case" and look to eliminate it as not concise or extra words. I also think this is another example of a wall of text and needs to be reduced/reorganized a bit. I will leave that to you since we have gone through an exercise or two of that.
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: jc-berger, sahare The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
See Jira: https://issues.redhat.com/browse/ACM-13324