Scopeguard advice. #24
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sean-parent
reviewed
Aug 27, 2024
| under mutation may exposed outside the class other than by | ||
| returning, e.g. if it is passed to a callback function. | ||
|
|
||
| 2. If your function reports errors to the caller other than by |
There was a problem hiding this comment.
That is not true - scope_success only checks on non-exception exit (hense "success"). You might want a caveat that this does not check the invariant in case of an exception (and why) - and scope_exit can be used if the check should be done even in case of an exception.
There was a problem hiding this comment.
You missed the words "other than." I'm talking about functions that e.g. return error codes.
|
Closing as obsolete |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.