Correlation volcano improvements #2659
Draft
+32
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
xzhou82
reviewed
Jan 24, 2025
| .on('click', () => { | ||
| interactions.launchSampleScatter(item) | ||
| }) | ||
|
|
||
| new ItemToolTip(item, circle, this.dom.tip, settings) | ||
| //Animate the circle to its final radius | ||
| circle.transition().duration(500).attr('r', item.radius) |
There was a problem hiding this comment.
it should transition the x/y location as well (assuming it uses enter/update)
There was a problem hiding this comment.
This is addressed in 95486e0.
There was a problem hiding this comment.
this x/y transitioning starts from top, is not what i mean. it should use the previous x/y values of each dot.
xzhou82
previously approved these changes
Jan 24, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Closes issue #2653 .
Changes:
Test with all pharma example.
Checklist
Check each task that has been performed or verified to be not applicable.