Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix any implicit return types #683

Merged
merged 1 commit into from
Oct 13, 2023
Merged

Fix any implicit return types #683

merged 1 commit into from
Oct 13, 2023

Conversation

adamalfredsson
Copy link
Collaborator

@adamalfredsson adamalfredsson commented Sep 28, 2023

Continuing a little bit with multiple cause areas. This wasn't really necessary for #684, just helpful in figuring out the inferred return types, so I put this in a separate PR.


Tested on devices

  • Desktop 💻
  • Mobile 📱

Tests

  • All tests are running ✔️
  • Test are updated 🧪
  • Code Review 👩‍💻
  • QA 👌

Checkpoints

Check these to flag for a more thurough review, as they could be potentially breaking changes

  • Packages updated
  • Other infrastructure updated (such as node version or similar)

⏲️ Time spent on CR:

⏲️ Time spent on QA:

@adamalfredsson adamalfredsson marked this pull request as ready for review September 28, 2023 13:45
@fellmirr fellmirr merged commit 9c968c4 into master Oct 13, 2023
2 checks passed
@fellmirr fellmirr deleted the fix-implicit-return-types branch October 13, 2023 10:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants