Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JOSS review: Download and cache datasets #18

Closed
rmsare opened this issue Oct 18, 2019 · 1 comment · Fixed by #20
Closed

JOSS review: Download and cache datasets #18

rmsare opened this issue Oct 18, 2019 · 1 comment · Fixed by #20
Assignees

Comments

@rmsare
Copy link
Collaborator

rmsare commented Oct 18, 2019

Finally, I wonder whether it is essential to include a 21.6 MB example data which practically accounts for the totality of the size of the Python wheel or source tar. I believe that it would be better to include such example data in a separate repository (e.g., with the example notebooks there instead of in docs/source/examples) or hosted on an s3 instance so they are downloaded (and maybe cached locally) once the users call the load_ methods of the dataset module.

openjournals/joss-reviews#1777

@rmsare rmsare self-assigned this Oct 18, 2019
@rmsare rmsare changed the title Joss review: Download and cache datasets JOSS review: Download and cache datasets Oct 18, 2019
@rmsare
Copy link
Collaborator Author

rmsare commented Oct 20, 2019

I decided to keep the docs as-is, but now download and cache example data from S3.

A separate docs/examples repo would be good if this grows into a larger project with more diverse examples, I agree. Usually I prefer to have the docs and example nbs included in the main repo - I feel this makes it easier to browse for examples and maintain the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant